Comment 10 for bug 1716429

Revision history for this message
Mathieu Lafon (mlafon) wrote :

Hi Steve,

> When debian fixed this issue [...], they left the default to off, in order to not break [...]
> The update for Ubuntu 12.04 LTS included this default.

You're correct about debian, but this is not exactly what is in the 12.04 LTS update. The patch for precise has two issues:
- The default value for 'verify' in the source code (src/kerberos.c) is 1 (enabled) although pysrc/kerberos.py (only used for documentation) has 'verify=False'
- The 'verify' argument was not made optional in the PyArg_ParseTuple() call so whatever default value was specified, the call would fail if there was not 5 parameters.

So 12.04 LTS already broke existing setups (and I was personally impacted at that time).

The patch included in xenial has then fixes these issues:

pykerberos (1.1.5-2):
  * [d3133b6] Set verify=True in docs too. This makes the docs consistent
    with the default behaviour of the function.
  * [792f3b6] Make verify option really optional. So far it correctly
    defaulted to true but couldn't be skipped.