Comment 4 for bug 516241

Revision history for this message
Thierry Carrez (ttx) wrote :

Hey Jonas, thanks for your patch. Three minor changes you should apply to your debdiff :

- Set "Maintainer:" to "Ubuntu Developers" rather than "Ubuntu Core Developers" to follow the new spec
- "XSBC-Original-Maintainer::" should just have one colon ("XSBC-Original-Maintainer:")
- The patch should only special-case --delete-delay, so that an error always goes out, even in the event upstream adds a third variation of delete_during to the mix. Something like (pseudocode):

- rprintf(dying to avoid a --delete-during);
+ if(delete_during == 2) {
+ rprintf(dying to avoid a --delete-delay);
+ }
+ else {
+ rprintf(dying to avoid a --delete-during);
+ }

What do you think ?