Comment 27 for bug 1977491

Robie,

I'll have some time this evening or this weekend to test the package.

With regards to your initial question, I think there is some confusion from my earlier comment. What I meant in my query to Sergio was that I thought the following two tests cases should be run:
1) with the vfs streams_xattr configured
2) with vfs_streams_xattr AND vfs_fruit configured

This is because fruit is passing xattribs and Alternate Data Streams [ADSes] down to vfs_streams_xattr, when configured to use streams. Thus, it would be good to insure that any deltas in vfs_streams_xattr doesn't break the interaction with vfs_fruit.

I noted in an earlier comment here or in the linked Samba bugzilla that this particular bug was reproducible even when using a Linux client that wasn't trying to manipulate xattribs or ADSes. Therefore, and given the nature of the bug (see the Samba bugzilla), I'd expect a Windows client doing simple file operations, manipulating xattribs, or Alternate Data Streams [ADS] would likewise fail, in both test cases 1 & 2. It's perfectly valid for a Windows client to mount a share running vfs_fruit, and if it does, it is my understanding xattribs and ADSes are still being passed from fruit to streams_xattr.

Sergio pruned the main test case in the bug down to the absolute minimum to reproduce the bug. But he agreed with me above, that it would be good to have some regression tests that verify changes to both vfs_fruit or streams_xattr do not break streams_xattr alone or when layered under fruit, by running test case 1 & 2.

And, I think that you bring up an excellent point that for a regression suite it would be worth having additional test cases that not only do simple file operations with all OS clients, but also specifically run tests 1 & 2 with both a macOS AND Windows client manipulating xattribs or ADSes on the share too, as I believe that both Windows and macOS are the only client OSes that natively use ADSes.