Comment 7 for bug 102577

Revision history for this message
Oliver Gerlich (ogerlich) wrote :

So after some longer pause I looked into this (and into Python) again and noticed that dirs_in is indeed a list, instead of a hash (dictionary), so do_add_file() will inefficiently search through all 200.000+ entries instead of doing a fast hash-lookup. Changing the three occurrences of dirs_in to a hash speeds up the first full backup of the test case from about 75 minutes to about 5 minutes; fprops creation only takes about one minute now instead of 70 minutes. Attached is a patch - could you review it?

The incremental backup is taking very long (still). Maybe there's another problem yet (or the hash patch has worsened the incremental case :)