Comment 7 for bug 1152187

Revision history for this message
Michael Terry (mterry) wrote :

And now for the packaging/maintainability review. I looked only at version 198 in raring-proposed.

* Packaging is understandably complex. Not only are there lots of vaguely-related components in this one source, but they are system-level core bits.
* Builds cleanly.
* Has bug subscribers.
* Both desktop and foundation teams are looking after the package.
* Existing bugs seem tolerable (most of them deal with the init pieces anyway). Should keep a watch on Debian bug 701364, which says it ftbfs with gcc-4.8.
* Uses symbols files.
* Uses python2, but does so with dh_python2 and the python-systemd package is not likely to be pulled onto the Desktop CD, so that's fine.

Seems almost OK. This will definitely not be a hands-off package, but it's important enough for us to accept the burden.

The one big beef I have is that we don't run any of the unit tests, because some of them fail (pitti says they make assumptions that aren't true on Ubuntu). I'd like to see those fixed or the rest of the unit tests enabled, so we have at least some coverage.