Comment 13 for bug 1597415
Revision history for this message
| Michael Doube (michael-doube) wrote | #13 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
This bug definitely depends on kernel version. Both the fix mentioned above in #8 https:/
:~/linux/linux$ git bisect bad
e075b3c898e4055
commit e075b3c898e4055
Author: Pali Rohár <email address hidden>
Date: Wed Jun 15 21:49:13 2016 +0200
dell-wmi: Generate one sparse keymap for all machines
This patch reworks code for generating sparse keymap and processing WMI
events. It unifies procedure for generating sparse keymap and also unifies
big switch code for processing WMI events of different types. After this
patch dell-wmi driver does not differ between "old" and "new" hotkey type.
It constructs sparse keymap table with all WMI codes. It is because on some
laptops (e.g. Dell Latitude E6440) ACPI/firmware send both event types (old
and new).
Each WMI code in sparse keymap table is prefixed by 16bit event type, so it
does not change functionality on laptops with "old" hotkey support (those
without scancodes in DMI).
This allow us to distinguish between same WMI codes with different types in
sparse keymap. Thanks to this WMI events of type 0x0011 were moved from big
switch into sparse keymap table too.
This patch also fixes possible bug in parsing WMI event buffer introduced
in commit 5ea2559726b7 ("dell-wmi: Add support for new Dell systems"). That
commit changed buffer type from int* to u16* without fixing code. More at:
http://
Signed-off-by: Pali Rohár <email address hidden>
Tested-by: Michał Kępień <email address hidden>
Reviewed-by: Michał Kępień <email address hidden>
Tested-by: Gabriele Mazzotta <email address hidden>
Signed-off-by: Darren Hart <email address hidden>
:040000 040000 babec68576f8756