Comment 0 for bug 297301

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.7+) Gecko/20020122
BuildID: 2002012208

If a POP server login attempt fails, Mozilla prompts for a new POP
server password. If the user clicks CANCEL, Mozilla nevertheless forgets
the old password (saved by the password manager), and refuses to
perform another mail fetch attempt until the user re-types
the POP server password.

Instead, CANCEL should leave the old password untouched,
i.e., act as if the cancelled transaction never happened.

I run into this frequently because I have my desktop set up to
automatically run "mozilla -mail" whenever I log in. This causes
a POP server connection to be made immediately, and a login begun;
then Mozilla prompts for the Master Password and waits.
If I am busy with other work, then I don't type in the Master PW
immediately, and the POP server times out. When I eventually type
the master PW, a POP timeout error occurs. Then Mozilla prompts
for a new POP server password. If I click CANCEL to this request,
Mozilla still forgets the old password and refuses to fetch any mail
until I re-type the POP password (which means I have to remember it :-)

I think two things should be done:

1. Don't connect to the POP server until after fetching the password.
   This will ensure that the POP login protocol won't time out if the
   user waits too long to enter the Master Password. This avoids bogus
   timeout errors altogether.

2. When CANCEL is clicked in any password prompt, do not
   erase the old password, but leave it unchanged.

Reproducible: Always
Steps to Reproduce:
1.Configure a POP mail account with a password, and enable saving it
  in the password manager. Enable encrypted data in the PW manager.
  Enable fetching POP mail automatically at startup.
2.Exit Mozilla and restart "mozilla -mail"
  (Master Password prompt appears)
3.Wait long enough for the POP server to time out (10-15 minutes is
  enough for yahoo).
4.Then enter the master PW.
  (a POP timeout error is displayed)
  (A new POP password is prompted for)
5.Click CANCEL to the prompt for a new POP server password.
6.Click Get Msgs to re-attempt the POP fetch.

Actual Results: Mozilla again asks for a new POP server password,
apparently having erased the old one even though CANCEL was clicked
in the previous new-password prompt.

Expected Results: Mozilla should not connect to the POP server until
after fetching the password, and Mozilla should not forget a password
if CANCEL is clicked in a prompt for a new password.