Comment 1 for bug 123124

Revision history for this message
Nicolò Chieffo (yelo3) wrote :

I've looked at the code in src/plugins/totem-screensaver.c

static void totem_screensaver_update_from_state (TotemObject *totem,
                     TotemScreensaverPlugin *pi)
{
    if (totem_is_playing (totem) != FALSE
        && totem_is_fullscreen (totem) != FALSE) {
        totem_scrsaver_disable (pi->scr);
    } else {
        totem_scrsaver_enable (pi->scr);
    }
}

I really think that this condition in inadequate: why the check that totem is fullscreen? I mean, I can prefer watching the video in windowed mode, especially if the resolution is not hi...

the check should be if totem_is_playing && totem_is_playing_video_file. Remember that there is the problem of inhibit the suspend, which should be done also if totem is playing an audio file (don't know if this is done elsewhere).
the function totem_is_playing_video_file should be implemented