Looks ok to me from a Feature Freeze perspective (but it would be nice to have an answer to Yuan-Chen's concern, from a technical perspective).
Aside, on ubuntu-drivers-common:
+Files: share/hybrid/json-parser/* +Copyright: Copyright (c) 2012, 2013 James McLaughlin et al. +License: BSD +
Please don't use 'BSD' as a license descriptor, it's ambiguous. https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#license-specification
(also, is there a reason you're embedding a json parser instead of building against json-c which is supported in main?)
On nvidia-prime:
> + self._nvidia_runtimepm_file = '/lib/modprobe.d/nvidia-runtimepm.conf'
Why are you managing files under /lib instead of under /etc? (this is a preexisting pattern so not a blocker, but it would be nice if this could be corrected at some point)
Looks ok to me from a Feature Freeze perspective (but it would be nice to have an answer to Yuan-Chen's concern, from a technical perspective).
Aside, on ubuntu- drivers- common:
+Files: share/hybrid/ json-parser/ *
+Copyright: Copyright (c) 2012, 2013 James McLaughlin et al.
+License: BSD
+
Please don't use 'BSD' as a license descriptor, it's ambiguous. https:/ /www.debian. org/doc/ packaging- manuals/ copyright- format/ 1.0/#license- specification
(also, is there a reason you're embedding a json parser instead of building against json-c which is supported in main?)
On nvidia-prime:
> + self._nvidia_ runtimepm_ file = '/lib/modprobe. d/nvidia- runtimepm. conf'
Why are you managing files under /lib instead of under /etc? (this is a preexisting pattern so not a blocker, but it would be nice if this could be corrected at some point)