Comment 6 for bug 405847

Revision history for this message
Steven Shiau (stevenshiau) wrote :

Thanks for the bug fixed. However, the code in the http://bazaar.launchpad.net/~scott/upstart/0.6/revision/1206 will _REPLACE_ the DEFAULT_RUNLEVEL even if /etc/inittab is something like:
#id:3:initdefault:
i.e. a commented line beginning with "#".
Maybe it's better to make it like:
eval "$(sed -nre 's/^[^#][^:]+:([0-6sS]):initdefault:.*/DEFAULT_RUNLEVEL="\1";/p' inittab || true)"

I believe you have better way to write it.
My 2 cents.