Comment 19 for bug 60915

Revision history for this message
J. Scott Berg (jsberg) wrote :

I'm attaching the debdiff, but I really wouldn't recommend this be released. It's a hack, cleaning up the mess that usplash left. Really we should prevent usplash from leaving a mess in the first place, because it may not only be scribbling on the palette registers.

My gut feeling from looking at the code is that the most straightforward fix would be to combine all the _init and _done stuff into a single routine (or a pair of routines, one in vga.c and one in vesa.c, the latter called directly by the former). There are int 10h calls to save and restore the VESA/VGA state, though some of these are commented out in svgalib for reasons I have yet to investigate. There may be some issues regarding the setting of the mode as well (my initial look indicated that my ATI card listed a bunch of VESA modes but then said that none of them were available, but this latter fact was ignored by svgalib; I still need to verify this more carefully; if this is the case, then we would need to use EDID requests to get modes, which is probably the right thing to do anyhow). As you said, this should all be discussed on ubuntu-developers...