Comment 22 for bug 663535

Revision history for this message
Reinhard Tartler (siretart) wrote : Re: [Bug 663535] Re: Extreme poor Video Quality in Empathy (jabber)

On Sun, Feb 27, 2011 at 04:22:26 (CET), Reşat SABIQ wrote:

>> Our options are:
>>
>> A) Fix libx264 : http://git.videolan.org/?p=x264.git;a=commitdiff;h=3d0d9cda1d39239e9f388fe1fce29c9212d0273c and http://git.videolan.org/?p=x264.git;a=commitdiff;h=5f104e9957cc4b69f7197fecf93648a0e2ae0e59
>
> Since when these 2 patches were ported they resulted in a serious issue,
> and were then reverted, are we still certain that this issue is fixed in
> latest stable x264? Perhaps we should first at least estimate which
> commits after the 2 above have really fixed the issue, and then
> upgrade...

we are certain that these commits do fix the issue. The problem is that
they change internal structures that require recompilation of *all*
users of x264. This is a no-go for a stable release update.

In order to follow the SRU protocol, the above fix needs to be rewritten
in a way that does not change the internal structures.

--
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4