Comment 14 for bug 115220

Revision history for this message
Bryce Harrington (bryce) wrote :

Here is a fix for this issue. It turned out that in early versions of EDID, 'aspect=0' was used to indicate a 1:1 aspect ratio, but in later versions like 1.3 and 2.0, they redefined it to mean a 16:10 aspect ratio. I guess ddcprobe was developed prior to this change, so was just assuming 1:1 for all versions of EDID info, and thus resulted in this bug.

The attached ddcprobe contains new logic, based on the xserver EDID handling code, to account for this properly. In addition, while looking at the code I saw that the 'aspect=3' case was simply incorrect; it is using a 16:10 ratio there, whereas in the specification, and in xserver, it clearly should be 16:9. I'm curious about this mistake, and why it appears not to have caused issues for anyone, but I suppose it's just a rare corner case, and probably hidden by other xresprobe bugs. Or maybe it's been reported elsewhere, or has symptoms that aren't being recognized as an xresprobe issue. In any case, I think coupled with the above fix, this may open up additional resolutions for users of 16:9 ratio hardware.