Comment 5 for bug 136962

Revision history for this message
Mario Limonciello (superm1) wrote :

I haven't actually applied/built/tested on my machine, but I see one more thing that sticks out to possibly cause trouble.

--- xserver-xgl-1.1.99.1~git20070727.orig/debian/xserver-xgl.preinst
+++ xserver-xgl-1.1.99.1~git20070727/debian/xserver-xgl.preinst
@@ -0,0 +1,17 @@
+#!/bin/sh -e
+
+OLD_CONF=/etc/X11/Xsession.d/00xserver-xgl_start-server
+OLD_CONF_MD5SUM=24a01acf61425d5cebec53ab07b57a90
+
+if [ "$1" = "upgrade" -o "$1" = "install" ] && \
+ [ "$2" = "1:1.1.99.1~git20070727-0ubuntu1" ] ; then
+ if [ -f $OLD_CONF ] ; then
+ if [ "$(md5sum $OLD_CONF | cut -f 1 -d ' ')" = "$OLD_CONF_MD5SUM" ] ;
+ then
+ # The old file has been left unchanged, we can delete it
+ rm -f $OLD_CONF
+ fi
+ fi
+fi
+

Hardcoding a version number and md5sum in the preinst seems like a bad idea. What happens when someone else on MOTU uploads a bug fix and doesn't see this hardcoded version and forgets to bump it?