Comment 9 for bug 225520

Revision history for this message
Hugues Fournier (hugues-fournier) wrote : Firefox 3 proxy auto config (PAC) reload button do not work

Binary package hint: xulrunner-1.9

The reload button in the network panel of Firefox 3 beta 5 has no effect.
This can be checked either by tcpdumping the request of Firefox, when clicking on the button, or by hosting locally a PAC file and watching the logs.

I have tracked it down this regression to the checkin upstream that introduced the influence of http_proxy environment variable on our systems on the proxy configuration of Firefox / XULrunner.

A new (intended) behaviour of nsProtocolProxyService::ConfigureFromPAC was introduced in this checkin : ConfigureFromPAC exits early if the uri is already known (this check was previously in other methods).

However nsProtocolProxyService::ReloadPAC (that is called by the reload button) calls ConfigureFromPAC with obviously the same uri than the one already known (otherwise this would not be a reload ;) )

Here is the patch I have submitted upstream :

https://bugzilla.mozilla.org/attachment.cgi?id=318657

The corresponding upstream bug is bugzilla 422172.