Andrew said:
> bzr-builddeb's import_dsc.DistributionBranch._do_import_package
> doesn't pass the upstream_md5 when it does:
>
> if not self.has_upstream_version(version.upstream_version):
>
> If it did I think it would probably DTRT here. What do other people
> think? Does this matter? Would adding “, upstream_md5” to that
> call be a good idea?
It has just occurred to me that *not* passing the md5 here is what allows you (in a non-importer situation, using bzr-builddeb commands interactively) to set an upstream-foo tag on an arbitrary revision which may not have a deb-md5 revision property at all, and have the importer trust you know what you are doing when you subsequently import-dsc a package using that upstream version.
Andrew said: dsc.Distributio nBranch. _do_import_ package upstream_ version( version. upstream_ version) :
> bzr-builddeb's import_
> doesn't pass the upstream_md5 when it does:
>
> if not self.has_
>
> If it did I think it would probably DTRT here. What do other people
> think? Does this matter? Would adding “, upstream_md5” to that
> call be a good idea?
It has just occurred to me that *not* passing the md5 here is what allows you (in a non-importer situation, using bzr-builddeb commands interactively) to set an upstream-foo tag on an arbitrary revision which may not have a deb-md5 revision property at all, and have the importer trust you know what you are doing when you subsequently import-dsc a package using that upstream version.
This may or may not be a desired feature.