Comment 29 for bug 1598298

Thank you for fixing upstream. I've been using variety 0.6.3 in Arch
Linux for a couple of months now, and it patches in the fix for the
menus. It's been working great for me. The person who maintains the
package will (most likely) adopt any changes upstream in future
releases.

If interested, Arch build (source files contains the patch it uses):
https://www.archlinux.org/packages/community/any/variety/

I will try the upstream version in Arch and see how it works, but it
may be a few days. I don't really have a need to go into Ubuntu
anytime soon though.

--
Jeremy MJ

On Thu, Mar 23, 2017 at 1:33 PM, Brian Murray <email address hidden> wrote:
> Hello Jeremy, or anyone else affected,
>
> Accepted variety into yakkety-proposed. The package will build now and
> be available at
> https://launchpad.net/ubuntu/+source/variety/0.6.2-1ubuntu1 in a few
> hours, and then in the -proposed repository.
>
> Please help us by testing this new package. See
> https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
> to enable and use -proposed.Your feedback will aid us getting this
> update out to other Ubuntu users.
>
> If this package fixes the bug for you, please add a comment to this bug,
> mentioning the version of the package you tested, and change the tag
> from verification-needed to verification-done. If it does not fix the
> bug for you, please add a comment stating that, and change the tag to
> verification-failed. In either case, details of your testing will help
> us make a better decision.
>
> Further information regarding the verification process can be found at
> https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in
> advance!
>
> ** Changed in: variety (Ubuntu Yakkety)
> Status: In Progress => Fix Committed
>
> ** Tags added: verification-needed
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1598298
>
> Title:
> Variety menu shows up in left corner, instead of under the icon
>
> Status in One Hundred Papercuts:
> Triaged
> Status in Variety:
> Fix Committed
> Status in variety package in Ubuntu:
> Fix Released
> Status in variety source package in Xenial:
> In Progress
> Status in variety source package in Yakkety:
> Fix Committed
>
> Bug description:
> Every time I click the Variety icon in the Mate panel, it shows the
> menu in the far left corner. It's been this way for several weeks now.
> I think it may have something to do with gtk 3.20. I'm using
> ArchLinux, and this behavior started about the time gtk 3.20 got
> pushed out.
>
> This error shows up when running Variety in verbose log mode and clicking the icon:
> TypeError: pos() takes exactly 2 arguments (4 given)
>
> I also attached the log.
>
> ArchLinux (x64, rolling), Linux desktop 4.6.3-1-ck
> Variety 6.0
> gtk 3.20
> mate 1.12
>
> ----
> Below is the SRU template (James Lu):
>
> [Impact]
>
> With newer versions of GTK+ / python-gi, some menus in Variety are
> showing up in the top left corner of the screen, instead of where the
> mouse clicks. Although this has no immediate impact on the menus'
> functionality, this bug is very noticeable when triggered and has been
> reported numerous times.
>
> [Test Case]
>
> A fair bit of menus are affected by this bug, including:
>
> * The menu that opens when clicking the "Add" button in Variety
> Preferences->General
>
> * The menu when right clicking a picture in the Wallpaper Selector
>
> * Some reporters have stated that this affects the menu that pops up
> from the Variety tray icon, but I haven't been able to reproduce this.
>
> [Regression Potential]
>
> I think the regression potential here is low, but any potential syntax
> errors or variable typos could break menus or cause the program to not
> start at all.
>
> Upstream suggests testing the following in particular:
> - Add and Remove buttons in Preferences should popup the menu exactly below the pressed button (like a dropdown).
> - Thumbs window's right-click menu should popup at mouse position (e.g. History, Wallpaper Selector)
> - Indicator should work both when using the indicator API (e.g. under Unity, or under Gnome with AppIndicator support extension installed - https://extensions.gnome.org/extension/615/appindicator-support/), as well as when using the StatusIcon API (e.g. under Gnome with no appindicator support).
>
> Also, other things I haven't tried include multi-monitor support, and
> menus on DEs other than Cinnamon and Xfce.
>
> [Other Info]
>
> Some time between Ubuntu 14.04 and 16.04 (from what I can gather from
> https://bugs.launchpad.net/variety/+bug/1598298/comments/23), the
> arguments for https://lazka.github.io/pgi-
> docs/#Gtk-3.0/callbacks.html#Gtk.MenuPositionFunc changed in a
> breaking manner. More specifically, what used to pass 2 arguments now
> passes 4. Part of this fix makes the relevant functions accept a
> variable amount of arguments, so that it should be compatible with all
> system versions.
>
> The other half of the fix is for the Variety indicator, and replaces a
> custom MenuPositionFunc using the old argument set with a static
> Gtk.StatusIcon.position_menu.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/hundredpapercuts/+bug/1598298/+subscriptions