Merge lp:~charon030/compiz-core/fix-751605 into lp:compiz-core
Status: | Merged |
---|---|
Approved by: | Christopher Townsend |
Approved revision: | 3127 |
Merged at revision: | 3135 |
Proposed branch: | lp:~charon030/compiz-core/fix-751605 |
Merge into: | lp:compiz-core |
Diff against target: |
126 lines (+19/-87) 2 files modified
src/screen.cpp (+5/-22) src/window.cpp (+14/-65) |
To merge this branch: | bzr merge lp:~charon030/compiz-core/fix-751605 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Christopher Townsend | Approve | ||
Daniel van Vugt | Needs Resubmitting | ||
Review via email: mp+134814@code.launchpad.net |
Commit message
Prevent windows from maximizing on the wrong monitor (LP: #751605)
This fixes two causes I have found:
1. outputDeviceFor
top or left) if a window was mostly off the bottom/right of the screen.
2. Even when outputDeviceFor
incorrect output in the case where the old size of a window exceeds
the dimensions of the smaller monitor you're trying to maximize it on.
Description of the change
I ported the same code changes Daniel van Vugt did in
https:/
to compiz-core (Compiz 0.9.7.x). This will allow users of Ubuntu 12.04 LTS to benefit from Daniel's bugfix.
Looks almost perfect, however I notice some whitespace changes on lines 117 and 119 compared to the original fix: /code.launchpad .net/~vanvugt/ compiz/ fix-751605/ +merge/ 134404
https:/
Please ensure the whitespace etc are identical to the original fix so we don't encounter conflicts in future.