Merge lp:~diegosarmentero/clickmanager-plugin/fix-compare-versions into lp:clickmanager-plugin
Proposed by
Diego Sarmentero
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Diego Sarmentero | ||||
Approved revision: | 15 | ||||
Merged at revision: | 13 | ||||
Proposed branch: | lp:~diegosarmentero/clickmanager-plugin/fix-compare-versions | ||||
Merge into: | lp:clickmanager-plugin | ||||
Diff against target: |
30 lines (+3/-6) 2 files modified
src/application.cpp (+2/-5) tests/testapplication.cpp (+1/-1) |
||||
To merge this branch: | bzr merge lp:~diegosarmentero/clickmanager-plugin/fix-compare-versions | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Manuel de la Peña (community) | Approve | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Roberto Alsina (community) | Approve | ||
Review via email: mp+188327@code.launchpad.net |
Commit message
- Fix versions comparison.
Description of the change
The code was expecting:
-1 for lower
0 for equal
1 for greater
And in fact it was returning the result of a substraction.
To post a comment you must log in.
PASSED: Continuous integration, rev:14 jenkins. qa.ubuntu. com/job/ clickmanager- plugin- ci/12/ jenkins. qa.ubuntu. com/job/ clickmanager- plugin- saucy-amd64- ci/12 jenkins. qa.ubuntu. com/job/ clickmanager- plugin- saucy-armhf- ci/12
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins: 8080/job/ clickmanager- plugin- ci/12/rebuild
http://