Merge lp:~stefanor/ibid/sqlite-index-warning into lp:~ibid-core/ibid/old-trunk-1.6

Proposed by Stefano Rivera
Status: Merged
Approved by: Jonathan Hitchcock
Approved revision: 909
Merged at revision: 930
Proposed branch: lp:~stefanor/ibid/sqlite-index-warning
Merge into: lp:~ibid-core/ibid/old-trunk-1.6
Diff against target: 12 lines (+1/-1)
1 file modified
ibid/db/versioned_schema.py (+1/-1)
To merge this branch: bzr merge lp:~stefanor/ibid/sqlite-index-warning
Reviewer Review Type Date Requested Status
Jonathan Hitchcock Approve
Michael Gorven Approve
Review via email: mp+24312@code.launchpad.net

This proposal supersedes a proposal from 2010-04-28.

Commit message

Incorrect substitution in SQLite indexing warning

Description of the change

Bug fix spotted by Russell.

Proposed for 0.1.1

To post a comment you must log in.
Revision history for this message
Michael Gorven (mgorven) wrote :

 review approve

review: Approve
Revision history for this message
Jonathan Hitchcock (vhata) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ibid/db/versioned_schema.py'
2--- ibid/db/versioned_schema.py 2010-01-17 20:28:33 +0000
3+++ ibid/db/versioned_schema.py 2010-04-28 12:45:28 +0000
4@@ -167,7 +167,7 @@
5 raise Exception(u"Column %s.%s is unique but not indexed. "
6 u"SQLite doesn't like such things, "
7 u"so please be nice and don't do that."
8- % (self.table.name, self.column.name))
9+ % (self.table.name, column.name))
10
11 # Strip out Indexes and Constraints that SQLAlchemy can't create by
12 # itself

Subscribers

People subscribed via source and target branches