New upstream release (0.8.0)

Apart from a new version, the changes add new packages for the extra language files in version 0.6+. These are distributed under somewhat different paths that in the old package, hence the new package names.

I have followed the same names as the maemo packaging guys did.

Thanks, I had a quick review, some comments:

- seems like some of the gstreamer sources changed license (gstpocketsphinx.c, gstvader.*, ...) from LGPL to what is used for the other sources, debian/copyright needs to be updated to reflect that

- the pkgconfig files has -lm added to its Libs.private, libpocketsphinx-dev should get a depends on libc6-dev

- it would be good to describe all the changes you did in the changelog, like you changed the short description to start with a capital letter ... was that a lintian warning?

- could you attach the orig.tar.gz to the bug? I noticed that it has a "dfsg" change to include some license text so it's likely a different tarball than the upstream one

Once those comments addressed it seems like it should be good to upload, I didn't spend a lot of time trying to understand the renaming though, it would be good if whoever re-review it/sponsoring it does that

- I've updated the copyright files as appropriate.

- Control file updated to add the missing dependency.

- I updated the casing just because all the other packages I looked at were that way.

- Not sure what do do about the orig.tar.gz, see next comment..

- I only versioned it dfsg because the previous version was also dfsg. It looks like originally the tarball was re-packaged to include a copy of the GPL license. Does this need to be done again? (I don't really know the rules around this) The copyright file refers to the licence in /usr/share/common-licenses/LGPL. Is that good enough?

In-case it's necessary, here's an updated orig.tar.gz that includes the COPYING.GPL and COPYING.LGPL files.

- The COPYING.GPL and COPYING.LGPL files no longer need to be manually added. Upstream changed the plugin from LGPL to BSD licensing, so everything is fine as is. Which means you should go back to an unmodified upstream tarball and drop the +dfsg1.

- I'm not quite clear on the reasons for the rename. I'm sure we have lots of package name differences between Ubuntu and Maemo. Is there a reason this difference is causing headaches?

- Even if the rename is good, you should add transitional dummy packages for the old names (using Section: oldlibs and just having a single Depends on the new package).

- You can drop the LGPL-2+ stanza from debian/copyright.

- I'm removing the dsfg stuff now

- The renames reflect the same re-organisation of the language models in the source tree now that it has more than just English languages.

- I will add the transitional packages.

- Doing this too.

I hope these changes address your concerns. I do think that it's important to indicate which language the models are for in the package names. I intend to be adding more language models for non-English in the future so that HUD on the phone and tablet can do voice recognition outside of just English.

Hey,

Thanks - I think I'm happy enough to upload this with a couple of minor tweaks from my end

 - Changing the Sentence case back to lower case in the short descriptions per http://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-pkg-synopsis
 - Removing the .la file which has nonempty dependency_libs

Also nice for the future would be to switch to 3.0 (quilt) instead of 1.0/dpatch (even though there are no patches) and to modernise the packaging to use dh(1) and dh_python2.

Cheers!

OK I just removed dpatch completely as lintian complains about it and it's good to get rid of one more dep (it's deprecated). I also added Depends: ${misc:Depends} to all packages that didn't have it.

Sounds good to me!

Bumped Standards-Version to 3.9.4, set the copyright URL to the new http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ and fixed some new errors (changes from previous spec version). Building now; will upload if it checks out. Thanks!

This bug was fixed in the package pocketsphinx - 0.8-0ubuntu1

---------------
pocketsphinx (0.8-0ubuntu1) raring; urgency=low

  [ Pete Woods ]
  * New upstream release (LP: #1110379)
  * Upgrading to latest release of pocketsphinx.
  * New lanuage model package for Mandarin.
  * New language model package organisation reflecting changes in the
    organisation of the codebase.

  [ Iain Lane ]
  * Don't install .la file
  * Bumped S-V to 3.9.4; no changes
  * Removed unused & deprecated dpatch usage
  * Set copyright format URL to current stable location and updated for
    changes since last spec version used.
 -- Pete Woods <email address hidden> Tue, 26 Feb 2013 15:13:49 +0000