Mahara

allow and moderate comments not saving correctly for groups

Bug #1201174 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Son Nguyen
Mahara 15.10.0
1.10
Fix Released
Medium
Unassigned
Mahara 1.10.7
15.04
Fix Released
Medium
Robert Lyon
Mahara 15.04.4
16.04
Fix Released
High
Robert Lyon
Mahara 16.04.0

Bug Description

When you do not allow commenting for all access groups, but only for a specific one and click "Save", the commenting permissions are not written to the DB. You have to go back in to the "Edit access" screen and tick the checkboxes for "Allow comments" and "Moderate" for that particular access group again and click "Save". Only then are the permissions saved.

Tags: feedback
Robert Lyon (robertl-9)
tags: added: feedback
Aaron Wells (u-aaronw)
Changed in mahara:
importance: Undecided → Medium
assignee: nobody → Aaron Wells (u-aaronw)
Aaron Wells (u-aaronw)
Changed in mahara:
status: New → Triaged
milestone: none → 1.10.3
Son Nguyen (ngson2000)
Changed in mahara:
milestone: 1.10.3 → 1.10.4
Revision history for this message
Robert Lyon (robertl-9) wrote :

On 15.10 when I check 'allow' and uncheck 'moderate' and save on page reload I end up with 'allow' unchecked and 'moderate' checked

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/5509

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/5510

Revision history for this message
Robert Lyon (robertl-9) wrote :

To test:

1) Create a page

2) Then click "Share page"

3) Add a few 'shared with' option
- before patch you should see 'Allow Moderate' column checkbox options, with patch they should be hidden at this point

4) Then click "Advanced options" and turn off the 'Allow comments' option there
- with patch this should now show the 'Allow Moderate' column checkbox options (and they should hide again if you turn on the 'Allow comments' option again)

5) Check the allow and moderate options - make some different selections for the rows

6) Then save the access

7) Then edit the access for the page again to make sure the right things are checked correctly.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5510
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/c541ba8c4b3c02fc16567325248f2f45dbea968b
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit c541ba8c4b3c02fc16567325248f2f45dbea968b
Author: Robert Lyon <email address hidden>
Date: Tue Oct 13 15:11:15 2015 +1300

Bug 1201174: Correctly saving access rules for allowing comments

When turning off allowcomments page-wise and adding them per 'Share
with' options

Change-Id: Ic367fa89a04fa91c655c3f42005685181b948f78
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5611

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5611
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/a149fd96bb89dcde804b9dfea34cc3895f77f154
Submitter: Aaron Wells (<email address hidden>)
Branch: 15.10_STABLE

commit a149fd96bb89dcde804b9dfea34cc3895f77f154
Author: Robert Lyon <email address hidden>
Date: Tue Oct 13 15:11:15 2015 +1300

Bug 1201174: Correctly saving access rules for allowing comments

When turning off allowcomments page-wise and adding them per 'Share
with' options

Change-Id: Ic367fa89a04fa91c655c3f42005685181b948f78
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit c541ba8c4b3c02fc16567325248f2f45dbea968b)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "1.10_STABLE" branch: https://reviews.mahara.org/5626

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5626
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/7d517b6476abeb2ea13fb2a1bad8bc09f03e2c2c
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.10_STABLE

commit 7d517b6476abeb2ea13fb2a1bad8bc09f03e2c2c
Author: Robert Lyon <email address hidden>
Date: Tue Oct 13 15:11:15 2015 +1300

Bug 1201174: Correctly saving access rules for allowing comments

When turning off allowcomments page-wise and adding them per 'Share
with' options

behatnotneeded

Change-Id: Ic367fa89a04fa91c655c3f42005685181b948f78
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/5509
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/c02200929d74d145fae1b37cabf5497e4db70df8
Submitter: Son Nguyen (<email address hidden>)
Branch: 15.04_STABLE

commit c02200929d74d145fae1b37cabf5497e4db70df8
Author: Robert Lyon <email address hidden>
Date: Tue Oct 13 15:11:15 2015 +1300

Bug 1201174: Correctly saving access rules for allowing comments

When turning off allowcomments page-wise and adding them per 'Share
with' options

behatnotneeded

Change-Id: Ic367fa89a04fa91c655c3f42005685181b948f78
Signed-off-by: Robert Lyon <email address hidden>

Kristina Hoeppner (kris-hoeppner)
no longer affects: mahara/15.10
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.