unity-webapps-qml

Could not create desktop file

Bug #1211352 reported by Víctor R. Ruiz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
unity-webapps-qml
Fix Released
Critical
Alexandre Abreu
unity-webapps-qml (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

In Jenkins' log, this critical error is displayed:

Could not create desktop file: "/home/ubuntu/.local/share/applications/HUDTESTlocalhost.desktop"

I checked in my VirtualBox Saucy installation, and the parent directory, ~/.local/share/applications/, is not created by default. Quickly checking the code, it seems that it expects the directory to be available.

   QFile f(desktopFilePath);
    if ( ! f.open(QIODevice::WriteOnly))
    {
        qCritical() << "Could not create desktop file: " << desktopFilePath;
        return success;
    }

Code must be added to create that folder. The program cannot expect it to be available.

Related branches

lp:~vrruiz/unity-webapps-qml/fix-sharelocalapps
PS Jenkins bot (community): Approve (continuous-integration)
Francis Ginther: Approve
Robert Bruce Park (community): Approve
Diff: 22 lines (+10/-2)
1 file modified
src/Ubuntu/UnityWebApps/plugin/unity-webapps-api.cpp (+10/-2)
lp:ubuntu/saucy-proposed/unity-webapps-qml
Víctor R. Ruiz (vrruiz)
Changed in unity-webapps-qml:
importance: Undecided → Critical
Revision history for this message
Víctor R. Ruiz (vrruiz) wrote :

When .local/share/applications is not available, the autopilot tests fail:

Traceback (most recent call last):
  File "/home/ubuntu/unity-webapps-qml/tests/integration/autopilot/unity_webapps_qml/tests/test_hud.py", line 40, in test_addAction
    self.assertThat(lambda: self.eval_expression_in_page_unsafe("return document.getElementById('status').innerHTML;"), Eventually(Equals('actionadded')))
MismatchError: After 10.0 seconds test failed: 'actionadded' != u''

So, this bug is related to https://bugs.launchpad.net/unity-webapps-qml/+bug/1208355

Víctor R. Ruiz (vrruiz)
Changed in unity-webapps-qml:
status: New → In Progress
assignee: nobody → Víctor R. Ruiz (vrruiz)
assignee: Víctor R. Ruiz (vrruiz) → Alexandre Abreu (abreu-alexandre)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:unity-webapps-qml at revision 36, scheduled for release in unity-webapps-qml, milestone Unknown

Changed in unity-webapps-qml:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity-webapps-qml - 0.1+13.10.20130816.1-0ubuntu1

---------------
unity-webapps-qml (0.1+13.10.20130816.1-0ubuntu1) saucy; urgency=low

  [ Víctor R. Ruiz ]
  * Create ./local/share/applications when not available. (LP: #1211352)

  [ Alexandre Abreu ]
  * Fix race condition in webapps bridge creation Fix issues in
    messaging menu Add facebookmessenger full example Fix initialization
    of backends Only inject API in top frame Fix issue with absence of
    'unsafeWindow'.
  * Add unitytestcase base class, seems to fix some dbus setup issues
    that some had
  * Remove unecessary unity property (already provided)

  [ Łukasz 'sil2100' Zemczak ]
  * Revert back to using Arch: any instead of explicitly listing out all
    architectures.

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 36
 -- Ubuntu daily release <email address hidden> Fri, 16 Aug 2013 10:04:26 +0000

Changed in unity-webapps-qml (Ubuntu):
status: New → Fix Released
Alexandre Abreu (abreu-alexandre)
Changed in unity-webapps-qml:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.