checkinstall fails to add files to dpkg conffiles

Bug #1304760 reported by Brian Morton
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
checkinstall (Debian)
Fix Released
Unknown
checkinstall (Ubuntu)
Fix Released
Medium
Brian Morton

Bug Description

checkinstall 1.6.2-3ubuntu1 has a command like this to create conffiles:

find -L $BUILD_DIR/etc -type f 2> /dev/null | sed -e "s,$BUILD_DIR,," | \
        > $BUILD_DIR/DEBIAN/conffiles

It is attempting to pipe and redirect the output, resulting in an empty conffiles. Removing the second pipe

find -L $BUILD_DIR/etc -type f 2> /dev/null | sed -e "s,$BUILD_DIR,," \
        > $BUILD_DIR/DEBIAN/conffiles

correctly creates the conffiles file.

Tags: patch
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in checkinstall (Ubuntu):
status: New → Confirmed
Revision history for this message
Szépe Viktor (szepe.viktor) wrote :

Could you please merge it.

It is a simple bug and is solved.

Thanks.

Revision history for this message
Brian Morton (rokclimb15) wrote :

This bug doesn't affect upstream, but is a regression from https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=655453 which was filed and fixed in Debian. The Debian patch is the source of this bug since the fix was incorrect. I'm reporting it to Debian and adding a note to the upstream bug to revise the fix before commit. I'll add an Ubuntu debdiff as a patch so it can easily be removed when this package is synced again.

Changed in checkinstall (Ubuntu):
assignee: nobody → Brian Morton (rokclimb15)
Revision history for this message
Brian Morton (rokclimb15) wrote :

After further research, the regression has been reported to Debian and a patch is attached to that report. It does not appear to have been applied. Debdiff attached for precise.

Changed in checkinstall (Debian):
status: Unknown → New
Revision history for this message
Brian Morton (rokclimb15) wrote :

Debdiff for Trusty and all newer releases.

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "Debdiff for precise" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Mathew Hodson (mhodson)
Changed in checkinstall (Ubuntu):
importance: Undecided → Medium
Revision history for this message
Brian Morton (rokclimb15) wrote :
Revision history for this message
Brian Murray (brian-murray) wrote :

I've uploaded this fix for Zesty, thanks for working on it. For this to be fixed in a stable release of Ubuntu we'll need a test case as described at http://wiki.ubuntu.com/StableReleaseUpdates. Do you know of one that we could use? Thanks in advance.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package checkinstall - 1.6.2-4ubuntu2

---------------
checkinstall (1.6.2-4ubuntu2) zesty; urgency=medium

  * 0012-fix-conffiles.patch: Fix bad pipe/redirect combo
    to enable conffiles generation (LP: #1304760)

 -- Brian Morton <email address hidden> Tue, 13 Dec 2016 21:07:00 -0500

Changed in checkinstall (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Brian Morton (rokclimb15) wrote :

root@checkinstall-bug-trusty:~# apt-get install checkinstall
root@checkinstall-bug-trusty:~# apt-get source haproxy
root@checkinstall-bug-trusty:~# cd haproxy*
root@checkinstall-bug-trusty:~/haproxy-1.5.14# mkdir -p etc/haproxy
root@checkinstall-bug-trusty:~/haproxy-1.5.14# touch etc/haproxy/haproxy.cfg
root@checkinstall-bug-trusty:~/haproxy-1.5.14# echo 'etc/haproxy/haproxy.cfg' >> includes
root@checkinstall-bug-trusty:~/haproxy-1.5.14# checkinstall -y --include=includes
root@checkinstall-bug-trusty:~/haproxy-1.5.14# dpkg -e haproxy*.deb
root@checkinstall-bug-trusty:~/haproxy-1.5.14# cat DEBIAN/conffiles | wc -l
0

after applying patched package of checkinstall, repeat the above steps

root@checkinstall-bug-trusty:~/haproxy-1.5.14# cat DEBIAN/conffiles | wc -l
1

Revision history for this message
Stephen Gelman (ssgelm) wrote :

FYI this is fixed in Debian in 1.6.2-6.

Changed in checkinstall (Debian):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.