Ubuntu
websockify package

nova-novncproxy and nova-spiceproxy need patched websockify

Bug #1350352 reported by GMi
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
websockify (Ubuntu)
Fix Released
High
Unassigned
Trusty
Fix Released
High
James Page
Utopic
Fix Released
High
Unassigned

Bug Description

[Impact]
Increasing number of zombie processes when using direct console access to instances within an openstack cloud on controller nodes.

[Test Case]
Deploy and configure openstack with either spice of novnc console access
Access a console via Horizon
Stop accessing console
(zombie process left on controller node)

[Regression Potential]
Fixes already applied in 0.6.0 release upstream, minimal regression potential.

[Original Bug Report]
Both nova-novncproxy and nova-spiceproxy produce zombie processes if they don't use the patched version of websockify.

websockify was patched a while back (https://github.com/kanaka/websockify/pull/96/files) and I would like to see the patch applied to the version supplied by ubuntu-cloud.

Tested on Ubuntu 12.04:
root@controller:/tmp/webs# lsb_release -rd
Description: Ubuntu 12.04.4 LTS
Release: 12.04

root@controller:/tmp/webs# apt-cache policy websockify
websockify:
  Installed: 0.5.1+dfsg1-3~cloud0
  Candidate: 0.5.1+dfsg1-3~cloud0
  Version table:
 *** 0.5.1+dfsg1-3~cloud0 0
        500 http://ubuntu-cloud.archive.canonical.com/ubuntu/ precise-updates/icehouse/main amd64 Packages
        100 /var/lib/dpkg/status

More info available in the original bug reported on Redhat:
https://bugzilla.redhat.com/show_bug.cgi?id=1013005

See original description
Revision history for this message
James Page (james-page) wrote :

Confirmed; I've see zombie processes when using spice

Changed in websockify (Ubuntu):
importance: Undecided → High
status: New → Triaged
Changed in nova (Ubuntu):
status: New → Invalid
Revision history for this message
GMi (gmi) wrote :

Same happens when using novnc.

Revision history for this message
James Page (james-page) wrote :

Utopic has 0.6.0 which has the required fixes; I'll cherry pick for trusty.

no longer affects: nova (Ubuntu)
Changed in nova (Ubuntu Trusty):
status: New → Invalid
Changed in websockify (Ubuntu Utopic):
status: Triaged → Fix Released
Changed in websockify (Ubuntu Trusty):
importance: Undecided → High
status: New → In Progress
assignee: nobody → James Page (james-page)
description: updated
Chris J Arges (arges)
no longer affects: nova (Ubuntu Trusty)
no longer affects: nova (Ubuntu Utopic)
Revision history for this message
Chris J Arges (arges) wrote : Please test proposed package

Hello GMi, or anyone else affected,

Accepted websockify into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/websockify/0.5.1+dfsg1-3ubuntu0.14.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in websockify (Ubuntu Trusty):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
GMi (gmi) wrote :

Tested the new websockify 0.5.1+dfsg1-3ubuntu0.14.04.1 on Ubuntu 12.04 and it works fine, no more zombie processes after accessing the spice console.

I don't know how to change the status of the bug from verification-needed to verification-done.

Thank you.

Mathew Hodson (mhodson)
tags: added: verification-done
removed: verification-needed
Revision history for this message
Scott Kitterman (kitterman) wrote : Update Released

The verification of the Stable Release Update for websockify has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package websockify - 0.5.1+dfsg1-3ubuntu0.14.04.1

---------------
websockify (0.5.1+dfsg1-3ubuntu0.14.04.1) trusty; urgency=medium

  * Fixup handling of child processes to avoid zombies (LP: #1350352):
    - d/p/avoid-zombies.patch,
      d/p/handle-multiprocessing.patch: Cherry picked fixes from upstream
      VCS to handle signals to child processes correctly.
 -- James Page <email address hidden> Thu, 31 Jul 2014 14:40:12 +0100

Changed in websockify (Ubuntu Trusty):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.