Mahara

Add caching of results to ArtefactType::get_plugin_name.

Bug #1364703 reported by Nigel Cunningham
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Wishlist
Nigel Cunningham
Mahara 15.10.0
15.10
Fix Released
Wishlist
Nigel Cunningham
Mahara 15.10.0

Bug Description

Add caching of results to ArtefactType::get_plugin_name.

In a test export of 1000 users via admin/users/bulkexport.php, the patch that goes with this bug reduced the number of calls to get_field from 78,000 to 26 and reduced the execution time from 115 seconds to 92 seconds.

Tags: performance
Nigel Cunningham (nigelc-g)
Changed in mahara:
assignee: nobody → Nigel Cunningham (nigelc-g)
status: New → In Progress
Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
importance: Undecided → Medium
Revision history for this message
Aaron Wells (u-aaronw) wrote :

Patch: https://reviews.mahara.org/#/c/3618/

tags: added: optimization
tags: added: performance
removed: optimization
Kristina Hoeppner (kris-hoeppner)
no longer affects: mahara/1.10
Aaron Wells (u-aaronw)
no longer affects: mahara/15.04
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/3618
Committed: http://gitorious.org/mahara/mahara/commit/6bc4db12bcbcb71d563946f650960e478edd300a
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 6bc4db12bcbcb71d563946f650960e478edd300a
Author: Nigel Cunningham <email address hidden>
Date: Mon Aug 4 10:20:39 2014 +1000

(Bug1364703) Add caching to ArtefactType::get_plugin_name

Add caching of results to ArtefactType::get_plugin_name.
In a test export of 1000 users via admin/users/bulkexport.php,
this patch reduced the number of calls to get_field from 78,000
to 26 and reduced the execution time from 115 seconds to 92 seconds.

Change-Id: Ie7b2e39089bed1c3cd4844748b21f1ffb251f8dd
Signed-off-by: Nigel Cunningham <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.