[tribe 5] aptitude ncurses interface refers to su vs sudo in status bar notes

Bug #139661 reported by Christer Edwards
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
aptitude (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

Binary package hint: aptitude

running the aptitude ncurses interface and selecting the "Become root" option from the menu (ctrl-t for the menu listings) displays:

"run su to become root; this will restart the program, but your settings will be preserved."

actually selecting that option presents the "[sudo] enter your password" prompt however.

This application and selection functions as expected, but the reference to su seems non-standard in a mainly sudo-based environment.

Related branches

Rolf Leggewie (r0lf)
Changed in aptitude:
importance: Undecided → Wishlist
status: New → Triaged
importance: Wishlist → Low
Revision history for this message
Rolf Leggewie (r0lf) wrote :

I have prepared a debdiff that I think should achieve this.

Revision history for this message
Rolf Leggewie (r0lf) wrote :

compiled binary to test and verify the patch. please release.

Revision history for this message
Rolf Leggewie (r0lf) wrote :

Did the following on the original patch and attach the updated patch here

sed s/root\.\ Your/root\,\ your/ LP139661.diff -i

I think this text fits in better

Changed in aptitude:
status: Triaged → In Progress
Revision history for this message
Steve Langasek (vorlon) wrote :

Hi Rolf,

+- N_("Run 'su' to become root; this will restart the program, but your settings will be preserved"), sigc::bind(sigc::ptr_fun(do_su_to_root), ""), sigc::ptr_fun(su_to_root_enabled)),
++ N_("Restart the program as root, your settings will be preserved"), sigc::bind(sigc::ptr_fun(do_su_to_root), ""), sigc::ptr_fun(su_to_root_enabled)),

Sorry, but this is a comma splice and grammatically incorrect. Would you mind regenerating the patch using a semicolon in place of this comma?

Revision history for this message
Rolf Leggewie (r0lf) wrote :

Did the following on the original patch and attach the updated patch here

sed s/root\.\ Your/root\;\ your/ LP139661.diff -i

I think this text fits better. Although it's ugly, the comma in the second version of the patch has been replaced by a semicolon to make sure this is grammatically correct.

Revision history for this message
Steve Langasek (vorlon) wrote :

Thanks. One further issue with the patch, which is that by running sed over the po directory, you appear to have modified all of the msgid values without leaving any indication that the translations are out-of-date. That would cause the original translations to continue to be used with minimal review, and no indication to the translation teams that a translation update is needed.

So I've adjusted the patch with a bit of magic (trim down the patch to only include the source and .pot changes; run dpatch-edit-patch with the correct locale set; ./configure && (cd po && touch aptitude.pot && make *.po); make distclean; exit 0). The amended patch is attached, which I believe is suitable for upload.

Unfortunately, aptitude fails to build for me in karmic - I don't know if this is a recent regression, or if it's a behavior change in g++-4.4. This needs more investigation yet.

Revision history for this message
Rolf Leggewie (r0lf) wrote :

Have the build problems in karmc been solved?

Revision history for this message
Steve Langasek (vorlon) wrote :

Unfortunately not. See bug #378997.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package aptitude - 0.4.11.11-1ubuntu3

---------------
aptitude (0.4.11.11-1ubuntu3) karmic; urgency=low

  * debian/patches/11_ubuntu_uses_sudo.dpatch:
    Fix status line of 'Become root' menu entry to not refer to su.
    (LP: #139661)

 -- Rolf Leggewie <email address hidden> Fri, 12 Jun 2009 15:59:11 +0000

Changed in aptitude (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.