Ubuntu
linux package

Mellanox updates for Trusty

Bug #1400127 reported by Eyal Perry
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
linux (Ubuntu)
Fix Released
High
Unassigned
Trusty
Fix Released
High
Chris J Arges
Utopic
Fix Released
High
Chris J Arges

Bug Description

SRU Justification:

[Impact]
Users of Mellanox mlx4_{core,en} drivers may be missing hardware enablement features.
[Test Case]
Test Mellanox hardware and ensure functionality with mlx4_{core,en} drivers.
[Fix]
As described below, and summarized in Comment #5.

--

The following changes since commit b87885d70c29324b66ee7d4f979a9f95cc46564b:

  UBUNTU: Ubuntu-3.13.0-42.71 (2014-12-05 14:35:11 +0000)

are attached to this tracker as patch files.

The main goal for this is patch-set is to add functionality to:
1. reduce cache misses by aligning CQE/EQE writes to the actual cache line size
2. set/get link speed using ethtool [-s].
3. set rx/tx vlan offload
4. bug fixes

all of the patches are upsream (net-next), except for the last one which is a bug fix waiting for review:
https://patchwork.ozlabs.org/patch/418451/

Ido Shamay (3):
      net/mlx4_core: Enable CQE/EQE stride support
      net/mlx4_core: Cache line EQE size support
      net/mlx4_en: Add mlx4_en_get_cqe helper

Saeed Mahameed (12):
      net/mlx4_core: Introduce mlx4_get_module_info for cable module info reading
      ethtool, net/mlx4_en: Cable info, get_module_info/eeprom ethtool support
      net/mlx4_core: Introduce ACCESS_REG CMD and eth_prot_ctrl dev cap
      net/mlx4_core: Add ethernet backplane autoneg device capability
      ethtool, net/mlx4_en: Add 100M, 20G, 56G speeds ethtool reporting support
      net/mlx4_en: Use PTYS register to query ethtool settings
      net/mlx4_en: Use PTYS register to set ethtool settings (Speed)
      net/mlx4_en: Add support for setting rxvlan offload OFF/ON
      net/mlx4_en: Add ethtool support for [rx|tx]vlan offload set to OFF/ON
      net/mlx4_core: Prevent VF from changing port configuration
      net/mlx4_en: mlx4_en_set_settings() always fails when autoneg is set
      net/mlx4_en: ethtool force speed when asking for autoneg=off

See original description
Revision history for this message
Eyal Perry (eyalpe) wrote :
Revision history for this message
Brad Figg (brad-figg) wrote : Missing required logs.

This bug is missing log files that will aid in diagnosing the problem. From a terminal window please run:

apport-collect 1400127

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

Changed in linux (Ubuntu):
status: New → Incomplete
Revision history for this message
Eyal Perry (eyalpe) wrote : Re: Mellanox updates for trsuty

This item is opened for tracking purposes, and more resembles a feature request than a bug in its nature.
Therefore I'm skipping the apport-collect script.

Revision history for this message
penalvch (penalvch) wrote :

Eyal Perry, thanks for providing the heads up on these commits. It is greatly appreciated.

summary: - Mellanox updates for trsuty
+ Mellanox updates for Trusty
tags: added: cherry-pick trusty
Changed in linux (Ubuntu):
importance: Undecided → High
status: Incomplete → Triaged
tags: added: bot-stop-nagging
Joseph Salisbury (jsalisbury)
tags: added: kernel-da-key
Chris J Arges (arges)
Changed in linux (Ubuntu):
assignee: nobody → Chris J Arges (arges)
Changed in linux (Ubuntu Trusty):
assignee: nobody → Chris J Arges (arges)
Changed in linux (Ubuntu Utopic):
assignee: nobody → Chris J Arges (arges)
importance: Undecided → High
Changed in linux (Ubuntu Trusty):
status: New → In Progress
importance: Undecided → High
Changed in linux (Ubuntu Utopic):
status: New → In Progress
Revision history for this message
Chris J Arges (arges) wrote :

Here is a summary of the commits:

From linus's tree:

77507aa249aecd06fa25ad058b64481e46887a01 net/mlx4_core: Enable CQE/EQE stride support
43c816c67a536cfcfc24da50153115b75eca94f0 net/mlx4_core: Cache line EQE size support
b1b6b4da7867d220f0da5f6686b869b304c5459b net/mlx4_en: Add mlx4_en_get_cqe helper

From net-next:

32a173c7f9e9ec2b87142f67e1478cd20084a45b net/mlx4_core: Introduce mlx4_get_module_info for cable module info reading
7202da8b7f7131d25411d81aa557e28cd941c5b6 ethtool, net/mlx4_en: Cable info, get_module_info/eeprom ethtool support
adbc7ac5c15eb5e9d70393428345e72a1a897d6a net/mlx4_core: Introduce ACCESS_REG CMD and eth_prot_ctrl dev cap
a53e3e8c1db547981e13d1ebf24a659bd4e87710 net/mlx4_core: Add ethernet backplane autoneg device capability
dcf972a334dd76975bf144ca57350c1f3132c947 ethtool, net/mlx4_en: Add 100M, 20G, 56G speeds ethtool reporting support
2c762679435dc812b7031ef9a839b901827294a9 net/mlx4_en: Use PTYS register to query ethtool settings
d48b3ab4c0e4356f3b1ccaea8cb838cf1292f7da net/mlx4_en: Use PTYS register to set ethtool settings (Speed)
7787fa661b8b9acba95ba35974b7092675baee8a net/mlx4_en: Add support for setting rxvlan offload OFF/ON
537f6f951e1489054c283fa97b636cc55af1a60b net/mlx4_en: Add ethtool support for [rx|tx]vlan offload set to OFF/ON
6e8066999800d90d52af5c84ac49ebf683d14cdc net/mlx4_core: Prevent VF from changing port configuration
312df74c712252017f0c2c12289f00b146ca72b3 net/mlx4_en: mlx4_en_set_settings() always fails when autoneg is set

Still under review:

https://patchwork.ozlabs.org/patch/418451/ net/mlx4_en: ethtool force speed when asking for autoneg=off

Changed in linux (Ubuntu):
status: Triaged → In Progress
Chris J Arges (arges)
description: updated
Revision history for this message
Chris J Arges (arges) wrote :

Sent pull-request(s) to Ubuntu kernel-team mailing list.

Revision history for this message
Chris J Arges (arges) wrote :

Sent v2 pull-request to ML with upstream only patches.

Brad Figg (brad-figg)
Changed in linux (Ubuntu Utopic):
status: In Progress → Fix Committed
Changed in linux (Ubuntu Trusty):
status: In Progress → Fix Committed
Revision history for this message
Brad Figg (brad-figg) wrote :

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-trusty' to 'verification-done-trusty'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-trusty
tags: added: verification-needed-utopic
Revision history for this message
Brad Figg (brad-figg) wrote :

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-utopic' to 'verification-done-utopic'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

Eyal Perry (eyalpe)
tags: added: verification-done-trusty verification-done-utopic
removed: verification-needed-trusty verification-needed-utopic
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (14.2 KiB)

This bug was fixed in the package linux - 3.16.0-30.40

---------------
linux (3.16.0-30.40) utopic; urgency=low

  [ Seth Forshee ]

  * Release Tracking Bug
    - LP: #1409890

  [ Andy Whitcroft ]

  * Revert "SAUCE: scsi: hyper-v storsvc switch up to SPC-3"
  * [Packaging] uploadnum should be the remainder of the version
    - LP: #1407755

  [ K. Y. Srinivasan ]

  * SAUCE: storvsc: force SPC-3 compliance on win8 and win8 r2 hosts
    - LP: #1406867

  [ Upstream Kernel Changes ]

  * Revert "xhci: clear root port wake on bits if controller isn't wake-up
    capable"
    - LP: #1408697
  * KVM: PPC: BOOK3S: HV: CMA: Reserve cma region only in hypervisor mode
    - LP: #1400209
  * powerpc/powernv: Ignore smt-enabled on Power8 and later
    - LP: #1402141
  * net/mlx4_en: Add VXLAN ndo calls to the PF net device ops too
    - LP: #1407760
  * net/mlx4_core: Enable CQE/EQE stride support
    - LP: #1400127
  * net/mlx4_core: Cache line EQE size support
    - LP: #1400127
  * net/mlx4_en: Add mlx4_en_get_cqe helper
    - LP: #1400127
  * net/mlx4_core: Introduce mlx4_get_module_info for cable module info
    reading
    - LP: #1400127
  * ethtool, net/mlx4_en: Cable info, get_module_info/eeprom ethtool
    support
    - LP: #1400127
  * net/mlx4_core: Introduce ACCESS_REG CMD and eth_prot_ctrl dev cap
    - LP: #1400127
  * net/mlx4_core: Add ethernet backplane autoneg device capability
    - LP: #1400127
  * ethtool, net/mlx4_en: Add 100M, 20G, 56G speeds ethtool reporting
    support
    - LP: #1400127
  * net/mlx4_en: Use PTYS register to query ethtool settings
    - LP: #1400127
  * net/mlx4_en: Use PTYS register to set ethtool settings (Speed)
    - LP: #1400127
  * net/mlx4_en: Add support for setting rxvlan offload OFF/ON
    - LP: #1400127
  * net/mlx4_en: Add ethtool support for [rx|tx]vlan offload set to OFF/ON
    - LP: #1400127
  * net/mlx4_core: Prevent VF from changing port configuration
    - LP: #1400127
  * net/mlx4_en: mlx4_en_set_settings() always fails when autoneg is set
    - LP: #1400127
  * sparc64: Fix constraints on swab helpers.
    - LP: #1408697
  * inetdevice: fixed signed integer overflow
    - LP: #1408697
  * ipv4: Fix incorrect error code when adding an unreachable route
    - LP: #1408697
  * ieee802154: fix error handling in ieee802154fake_probe()
    - LP: #1408697
  * qmi_wwan: Add support for HP lt4112 LTE/HSPA+ Gobi 4G Modem
    - LP: #1408697
  * bonding: fix curr_active_slave/carrier with loadbalance arp monitoring
    - LP: #1408697
  * pptp: fix stack info leak in pptp_getname()
    - LP: #1408697
  * ipx: fix locking regression in ipx_sendmsg and ipx_recvmsg
    - LP: #1408697
  * net/mlx4_en: Advertize encapsulation offloads features only when VXLAN
    tunnel is set
    - LP: #1408697
  * target: Don't call TFO->write_pending if data_length == 0
    - LP: #1408697
  * vhost-scsi: Take configfs group dependency during
    VHOST_SCSI_SET_ENDPOINT
    - LP: #1408697
  * srp-target: Retry when QP creation fails with ENOMEM
    - LP: #1408697
  * ASoC: fsi: remove unsupported PAUSE flag
    - LP: #1408697
  * ASoC: rsnd: remove unsupported PAUSE flag
    - LP: #1408697
  * ib_isert: Add max_send_sge...

Changed in linux (Ubuntu Utopic):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (9.0 KiB)

This bug was fixed in the package linux - 3.13.0-45.74

---------------
linux (3.13.0-45.74) trusty; urgency=low

  [ Seth Forshee ]

  * Release Tracking Bug
    - LP: #1410384

  [ Jesse Barnes ]

  * SAUCE: drm/i915/vlv: assert and de-assert sideband reset at boot and
    resume v3
    - LP: #1401963

  [ K. Y. Srinivasan ]

  * SAUCE: storvsc: force SPC-3 compliance on win8 and win8 r2 hosts
    - LP: #1406867

  [ Timo Aaltonen ]

  * SAUCE: Switch VLV/BYT to use i915_bdw.
    - LP: #1401963

  [ Upstream Kernel Changes ]

  * Revert "xhci: clear root port wake on bits if controller isn't wake-up
    capable"
    - LP: #1408779
  * KVM: PPC: BOOK3S: HV: CMA: Reserve cma region only in hypervisor mode
    - LP: #1400209
  * e1000e: Fix no connectivity when driver loaded with cable out
    - LP: #1400365
  * net/mlx4_core: Enable CQE/EQE stride support
    - LP: #1400127
  * net/mlx4_core: Cache line EQE size support
    - LP: #1400127
  * net/mlx4_en: Add mlx4_en_get_cqe helper
    - LP: #1400127
  * net/mlx4_core: Introduce mlx4_get_module_info for cable module info
    reading
    - LP: #1400127
  * ethtool, net/mlx4_en: Cable info, get_module_info/eeprom ethtool
    support
    - LP: #1400127
  * net/mlx4_core: Introduce ACCESS_REG CMD and eth_prot_ctrl dev cap
    - LP: #1400127
  * net/mlx4_core: Add ethernet backplane autoneg device capability
    - LP: #1400127
  * ethtool, net/mlx4_en: Add 100M, 20G, 56G speeds ethtool reporting
    support
    - LP: #1400127
  * net/mlx4_en: Use PTYS register to query ethtool settings
    - LP: #1400127
  * net/mlx4_en: Use PTYS register to set ethtool settings (Speed)
    - LP: #1400127
  * net/mlx4_en: Add support for setting rxvlan offload OFF/ON
    - LP: #1400127
  * net/mlx4_en: Add ethtool support for [rx|tx]vlan offload set to OFF/ON
    - LP: #1400127
  * net/mlx4_core: Prevent VF from changing port configuration
    - LP: #1400127
  * net/mlx4_en: mlx4_en_set_settings() always fails when autoneg is set
    - LP: #1400127
  * ipv4: fix nexthop attlen check in fib_nh_match
    - LP: #1408779
  * vxlan: fix a use after free in vxlan_encap_bypass
    - LP: #1408779
  * vxlan: using pskb_may_pull as early as possible
    - LP: #1408779
  * vxlan: fix a free after use
    - LP: #1408779
  * ipv4: fix a potential use after free in ip_tunnel_core.c
    - LP: #1408779
  * ax88179_178a: fix bonding failure
    - LP: #1408779
  * tcp: md5: do not use alloc_percpu()
    - LP: #1408779
  * ipv4: dst_entry leak in ip_send_unicast_reply()
    - LP: #1408779
  * drivers/net, ipv6: Select IPv6 fragment idents for virtio UFO packets
    - LP: #1408779
  * drivers/net: macvtap and tun depend on INET
    - LP: #1408779
  * ip6_tunnel: Use ip6_tnl_dev_init as the ndo_init function.
    - LP: #1408779
  * vti6: Use vti6_dev_init as the ndo_init function.
    - LP: #1408779
  * sit: Use ipip6_tunnel_init as the ndo_init function.
    - LP: #1408779
  * gre6: Move the setting of dev->iflink into the ndo_init functions.
    - LP: #1408779
  * vxlan: Do not reuse sockets for a different address family
    - LP: #1408779
  * net: sctp: fix memory leak in auth key management
    - LP: #1408779
  * smsc911x: power-...

Read more...

Changed in linux (Ubuntu Trusty):
status: Fix Committed → Fix Released
Revision history for this message
Chris J Arges (arges) wrote :

All the aforementioned patches are in Vivid since it is based on 3.19 now, except "https://patchwork.ozlabs.org/patch/418451/ net/mlx4_en: ethtool force speed when asking for autoneg=off" this seems to not be in upstream Linux either. For now I'll mark this Fixed, and if there is a superceeded patch that needs to be applied please open a bug with the appropriate patches.

Thanks,

Changed in linux (Ubuntu):
status: In Progress → Fix Released
assignee: Chris J Arges (arges) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.