"Content -> Files" accessibility links show up when attempting to drag and drop

Bug #1443770 reported by Aaron Wells
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Aaron Wells
1.10
Fix Released
High
Aaron Wells
15.04
Fix Released
High
Aaron Wells
15.10
Fix Released
High
Aaron Wells

Bug Description

In 1.9 for accessibility purposes we added a feature to the "Content -> Files" screen, which makes it so that if you click on a thumbnail of a file, it shows you a list of locations you could move the file to. This is an accessible alternative to the drag-and-drop system for moving your files to different folders.

There are a couple of problems with this currently.

First, the patch that we added to make it work in IE, has the side effect that in Firefox and Chromium, the accessible alternative shows up when you start dragging and dropping, as opposed to when you just click on it. Also, the thumbnail shifts up and away from the mouse pointer at the same time, meaning you need to click on it, it pops open, then you have to move your mouse back over the thumbnail's new location.

To replicate:

1. Go to Content -> Files
2. Upload at least one file
3. Create a folder called "Test"
3. Move your mouse pointer over the thumbnail's icon and try to drag and drop the thumbnail icon onto the Test folder.

Expected result: You drag it onto the Test folder and drop it onto the Test folder. You do not see the accessibility options.

Actual result: When you depress the mouse button, the accessibility option shows up, and the thumbnail moves away out from under your pointer.

Using git bisect, I see this started with this patch, for IE support:

https://reviews.mahara.org/#/c/3521/1

Aaron Wells (u-aaronw)
tags: added: regression
summary: - "Content -> Files" accessiblity links for moving files, get in the way
- of drag-and-drop
+ "Content -> Files" accessibility links show up when attempting to drag
+ and drop
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/4610

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/4610
Committed: http://gitorious.org/mahara/mahara/commit/1bb15dcd92c6cd9a537c883bf4be3ba5ba6921e9
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 1bb15dcd92c6cd9a537c883bf4be3ba5ba6921e9
Author: Aaron Wells <email address hidden>
Date: Tue Apr 14 18:34:14 2015 +1200

Hide accessibility link on drag-and-drop.

Bug 1443770. Note this solution doesn't work fully in IE10.
In that browser, the keyboard nav works, but clicking on the
thumbnail won't pop open the accessibility links.

The fix for that, is ultimately to change this from using
MochiKit to using JQuery.

Change-Id: I5f173f6b32a3a301c10262cd71838f78821b36dd

Revision history for this message
Aaron Wells (u-aaronw) wrote :

Changing the priority of this one to "High" because it's a visible problem.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/4622

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "1.10_STABLE" branch: https://reviews.mahara.org/4623

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/4623
Committed: http://gitorious.org/mahara/mahara/commit/69a6592df55a34943d08f1baae20b55fcab62bea
Submitter: Aaron Wells (<email address hidden>)
Branch: 1.10_STABLE

commit 69a6592df55a34943d08f1baae20b55fcab62bea
Author: Aaron Wells <email address hidden>
Date: Tue Apr 14 18:34:14 2015 +1200

Hide accessibility link on drag-and-drop.

Bug 1443770. Note this solution doesn't work fully in IE10.
In that browser, the keyboard nav works, but clicking on the
thumbnail won't pop open the accessibility links.

The fix for that, is ultimately to change this from using
MochiKit to using JQuery.

Change-Id: I5f173f6b32a3a301c10262cd71838f78821b36dd

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/4622
Committed: http://gitorious.org/mahara/mahara/commit/84cceea056ff00c21430cbe4584b1776a2d25c40
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit 84cceea056ff00c21430cbe4584b1776a2d25c40
Author: Aaron Wells <email address hidden>
Date: Tue Apr 14 18:34:14 2015 +1200

Hide accessibility link on drag-and-drop.

Bug 1443770. Note this solution doesn't work fully in IE10.
In that browser, the keyboard nav works, but clicking on the
thumbnail won't pop open the accessibility links.

The fix for that, is ultimately to change this from using
MochiKit to using JQuery.

Change-Id: I5f173f6b32a3a301c10262cd71838f78821b36dd

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
tags: added: behat-needed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.