Mahara

Bulk user export page has a redirect that doesn't work with subdirectories.

Bug #1446426 reported by Aaron Wells
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Aaron Wells
Mahara 15.10.0
15.04
Fix Released
Medium
Aaron Wells
Mahara 15.04.1
15.10
Fix Released
Medium
Aaron Wells
Mahara 15.10.0

Bug Description

This is a bug that shows up after you have successfully downloaded the bulk export from admin/users/bulkexport.php.

To replicate:

1. Set up your Mahara site so there is a subdirectory in its wwwroot. (e.g.: http://example.com/mahara/)
2. Go to http://example.com/mahara/admin/users/bulkexport.php and bulk export some users.

Expected result: You download the ZIP file, and are redirected back to http://example.com/mahara/admin/users/bulkexport.php
Actual result: You download the ZIP file, but are redirected to the broken URL http://example.com/admin/users/bulkexport.php

The problem is that the success redirect URL is a relative URL (/admin/users/bulkexport.php), when it needs to be an absolute URL starting with $CFG->wwwroot.

Tags: bulkexport
Revision history for this message
Aaron Wells (u-aaronw) wrote :

Medium priority, because the bulkexport.php page is hidden away. Easy fix, though, so we should backport it.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/4680

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/4680
Committed: http://gitorious.org/mahara/mahara/commit/b42f2bd1e5f3110bcf76602c3bd39ac01c185a36
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit b42f2bd1e5f3110bcf76602c3bd39ac01c185a36
Author: Aaron Wells <email address hidden>
Date: Tue Apr 21 12:50:26 2015 +1200

The redirect URL on the bulk export page should be absolute

Bug 1446426. Relative URLs don't work if your Mahara wwwroot
is a subdirectory, e.g. http://example.com/mahara

Change-Id: Idfbb4c1a81191a41c25fc816eec784cd14df7637

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/4703

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/4703
Committed: http://gitorious.org/mahara/mahara/commit/1b65c2be32286f29eabf73c0b65d9e1f9faaf931
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit 1b65c2be32286f29eabf73c0b65d9e1f9faaf931
Author: Aaron Wells <email address hidden>
Date: Tue Apr 21 12:50:26 2015 +1200

The redirect URL on the bulk export page should be absolute

Bug 1446426. Relative URLs don't work if your Mahara wwwroot
is a subdirectory, e.g. http://example.com/mahara

Change-Id: Idfbb4c1a81191a41c25fc816eec784cd14df7637

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.