Mahara setting the noreply@ email address wrong if on non 80 port

Bug #1447892 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon
15.10
Fix Released
Undecided
Unassigned

Bug Description

When a site is set up the noreplyaddress is set to: 'noreply@' + hostname but if the site has port specified then the email address ends up with a port number on the end.

We need to remove any port number as it's not a valid email address

Robert Lyon (robertl-9)
Changed in mahara:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Robert Lyon (robertl-9)
importance: Medium → High
milestone: none → 15.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/4695

Revision history for this message
Jinelle Foley-Barnes (jinelleb) wrote :

Hi,

How do I test this change specifically? I get the general sense of it, but I need to do it more specifically.

Thanks,
Jinelle

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/4695
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/1d2828d3cbc71f268a02db64384e28b27ce42874
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 1d2828d3cbc71f268a02db64384e28b27ce42874
Author: Robert Lyon <email address hidden>
Date: Fri Apr 24 15:42:19 2015 +1200

Stripping the port number from noreplyaddress (Bug #1447892)

In case the site has port specified in its server['HOST'].

Change-Id: Ia033270487a14a537dada5697b8c2d3848d490fa
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.