[Hyper-V] storvsc: Set the SRB flags correctly when no data transfer is needed

No log provided or required, upstream commit.

This bug is missing log files that will aid in diagnosing the problem. From a terminal window please run:

apport-collect 1454758

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

The commit requested in the description of this bug is now in the Ubuntu-3.19.0-22.22 Vivid kernel via the following:

commit 5db9ff87ac04da152ac8996025158f010adbfa8f
Author: K. Y. Srinivasan <email address hidden>
Date: Fri Jun 5 14:00:31 2015 -0400

    storvsc: Set the SRB flags correctly when no data transfer is needed

    BugLink: http://bugs.launchpad.net/bugs/1439780

    Set the SRB flags correctly when there is no data transfer. Without this
    change some IHV drivers will fail valid commands such as TEST_UNIT_READY.

This commit was included per bug 1439780 and is confirmed to have resolved that bug. The 3.19.0-22 kernel is now in the proposed repository.

Would it be possible for you to test this latest kernel and post back if it resolves this bug?
See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed.

Thank you in advance!

Also, in bug 1445195 we were talking about reliability issues when that bug was focused on performance improvements. So we will use this bug to focus on the reliability issues, which may or may not be resolved with only commit 5db9ff87 "storvsc: Set the SRB flags correctly when no data transfer is needed"

I'm also looking into bug 1452074 . Comment 4 in that bug sounds like the reliability issues we are talking about in bug 1445195. Joshua, should we use bug 1452074 to focus on the reliability issues and use this bug to focus on getting the commit in the description in all the stable releases?

Yes, let's go forward with that plan, although the SRB flag fix should not cause any instability... there must be another underlying issue.

As suggested in comment #13 of bug 1452074 , a new bug will be opened to focus on the issues seen with VSS Based Backups. This bug will be used to get the commit listed in the description into all stable releases.

The new bug is bug 1470250 . Let's now use that bug to focus on the VSS Backup issues.

The cherry-pick of commit dc45708c into Precise also required 8b612fa as a prereq. I built a test kernel with these two commits. The test kernel can be downloaded from:

http://kernel.ubuntu.com/~jsalisbury/lp1454758/

Can folks affected by this bug test this kernel? If it resolves this bug, I will SRU these commits to Precise.

Thanks in advance.

The add to my last comment, other prerequisits were also required to get a cherry-pick of commit dc45708c. The following commits were needed:

610071c38, 37f7278b8, eafa7072e and 8b612fa23

Tested the above test kernel (3.2.0-90-generic) on Ubuntu 12.04.5 without any errors.

@Joshua, would it be possible for you to test this bug as well. If these commits fix the bug as expected, I'll submit an SRU for Precuse.

@jsalisbury Joe, @v-zsduda is on my team. The update looks good.

Great, thanks for the update! I'll submit these patches for an SRU.

An SRU request for Precise has been submitted.

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-precise' to 'verification-done-precise'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

Hi Luis,
I've tested this now on Precise with kernel 3.2.0-95-generic and it's working fine.
Please merge the changes.

This bug was fixed in the package linux - 3.2.0-95.135

---------------
linux (3.2.0-95.135) precise; urgency=low

  [ Luis Henriques ]

  * Release Tracking Bug
    - LP: #1514808

  [ Upstream Kernel Changes ]

  * Drivers: hv: Support handling multiple VMBUS versions
    - LP: #1454758
  * Drivers: hv: Save and export negotiated vmbus version
    - LP: #1454758
  * Drivers: hv: Move vmbus version definitions to hyperv.h
    - LP: #1454758
  * storvsc: Update the storage protocol to win8 level
    - LP: #1454758
  * storvsc: Set the SRB flags correctly when no data transfer is needed
    - LP: #1454758

 -- Luis Henriques <email address hidden> Tue, 10 Nov 2015 12:06:14 +0000