Ubuntu
unity8-desktop-session package

Shell rotation breaks Greeter's wide view

Bug #1466947 reported by Josh Arenson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
unity8 (Ubuntu)
Fix Released
Undecided
Unassigned
unity8-desktop-session (Ubuntu)
New
Undecided
Josh Arenson

Bug Description

The shell rotation branch removed properties that the greeter relies on to determine if it should load wide/narrow view. Since the property was removed, the conditions always evaluate to false and only the NarrowView greeter can be loaded.

Related branches

lp:~dandrader/unity8/fixOrientedShellTests
Lukáš Tinkl (community): Approve
Josh Arenson: Approve
PS Jenkins bot (community): Needs Fixing (continuous-integration)
Albert Astals Cid (community): Abstain
Diff: 329 lines (+31/-49)
10 files modified
qml/OrientedShell.qml (+1/-0)
qml/Shell.qml (+13/-15)
src/ApplicationArguments.h (+5/-0)
src/main.cpp (+2/-1)
tests/autopilot/unity8/greeter/tests/test_args.py (+6/-6)
tests/qmltests/Stages/tst_SurfaceContainer.qml (+0/-1)
tests/qmltests/Tutorial/tst_Tutorial.qml (+3/-10)
tests/qmltests/tst_OrientedShell.qml (+1/-12)
tests/qmltests/tst_Shell.qml (+0/-2)
tests/qmltests/tst_ShellWithPin.qml (+0/-2)
lp:ubuntu/wily-proposed/unity8
Josh Arenson (josharenson)
Changed in unity8-desktop-session (Ubuntu):
assignee: nobody → Josh Arenson (josharenson)
Revision history for this message
Michael Zanetti (mzanetti) wrote :

Hmm. It does load the wide greeter on the Nexus7 tablet. On which environment are you testing this?

Revision history for this message
Josh Arenson (josharenson) wrote :

@mzanetti I'm not sure what I was using when I reported this (thought it was trunk). While I see that WideView should load, it _does_ check for tabletMode || multiUser when determining which view to load. Currently, nobody is setting the tabletMode property. Perhaps this is still a bug, just a very small one that currently doesn't show any symptoms? If https://code.launchpad.net/~dandrader/unity8/fixOrientedShellTests/+merge/262490 gets merged, it should resolve this issue and make things more clear as well.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity8 - 8.10+15.10.20150702.2-0ubuntu1

---------------
unity8 (8.10+15.10.20150702.2-0ubuntu1) wily; urgency=medium

  [ Albert Astals Cid ]
  * Save screenshots of suspended apps to disk
  * Set width of title label when inside the title row (LP: #1461979)
  * qmluitests was renamed to uitests

  [ CI Train Bot ]
  * Resync trunk.

  [ Daniel d'Andrada ]
  * Fix tst_OrientedShell and tst_Tutorial (LP: #1469761, #1466947)

  [ Leo Arias ]
  * Reorganized the python test helper modules. Deprecated the
    unity8.shell.emulators namespace. (LP: #1306340)

  [ Leonardo Arias Fonseca ]
  * Reorganized the python test helper modules. Deprecated the
    unity8.shell.emulators namespace. (LP: #1306340)

  [ Lukáš Tinkl ]
  * fix PO files extraction

  [ Michael Zanetti ]
  * Make use of QInputDeviceInfo in order to automatically switch
    between usage modes and hide the OSK.

  [ Nick Dedekind ]
  * Fixed qtmultimedia mock which was generating errors in tests

  [ Richard Huddie ]
  * Reorganized the python test helper modules. Deprecated the
    unity8.shell.emulators namespace. (LP: #1306340)

 -- CI Train Bot <email address hidden> Thu, 02 Jul 2015 16:09:57 +0000

Changed in unity8 (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.