Mahara

Terms and conditions not showing on register page for multi institutions

Bug #1471604 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Robert Lyon
Mahara 15.10.0
1.10
Fix Released
Medium
Robert Lyon
Mahara 1.10.5
1.9
Fix Released
Medium
Robert Lyon
Mahara 1.9.7
15.04
Fix Released
Medium
Robert Lyon
Mahara 15.04.2
15.10
Fix Released
Undecided
Unassigned

Bug Description

On the registration page - when a site has more than one institution to choose from the terms and conditions are not shown.

This is due to the page loading with the 'Choose your institution' initially and it doesn't have terms and conditions so the div container where the terms are meant to be placed is not on the page.

Need to put the container div outside the {if}{/if} statement so that js can populate it.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/4919

Robert Lyon (robertl-9)
Changed in mahara:
status: New → In Progress
Revision history for this message
Aaron Wells (u-aaronw) wrote :

To test:
1) Have a site with two (or more) institutions
2) For each institution have setting 'Registration allowed' turned on
3) To make testing easier have each institution's 'terms & conditions' be set to different text. To do this go to Institutions -> static pages and select 'terms .. ' from dropdown - turn 'Use site default' off and then alter the text and save.

Once all that is set up - log out and click the 'Register' button.

You should be able to pick institution on register form and the choice you pick should populate some terms text below the form.

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/4945

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "1.10_STABLE" branch: https://reviews.mahara.org/4946

Aaron Wells (u-aaronw)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "1.9_STABLE" branch: https://reviews.mahara.org/4947

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/4946
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/33ea03a90d271363077af4211b98ae658b3d5b8d
Submitter: Aaron Wells (<email address hidden>)
Branch: 1.10_STABLE

commit 33ea03a90d271363077af4211b98ae658b3d5b8d
Author: Robert Lyon <email address hidden>
Date: Mon Jul 6 09:39:44 2015 +1200

Bug 1471604: Terms & Conditions not displaying on register page

If there are more than one institution to choose from as the div
container 'termscontainer' is not present on page.

Change-Id: I5a7e03ff4bd0f8a5bcd933d37bbf81ca441cbf92
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/4947
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/120c93797c7bdfbc5c7b5e644b2e81e817fba6ea
Submitter: Aaron Wells (<email address hidden>)
Branch: 1.9_STABLE

commit 120c93797c7bdfbc5c7b5e644b2e81e817fba6ea
Author: Robert Lyon <email address hidden>
Date: Mon Jul 6 09:39:44 2015 +1200

Bug 1471604: Terms & Conditions not displaying on register page

If there are more than one institution to choose from as the div
container 'termscontainer' is not present on page.

Change-Id: I5a7e03ff4bd0f8a5bcd933d37bbf81ca441cbf92
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/4945
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/bfddcf285519e1d85be14c9547098f5b2d44d9ce
Submitter: Aaron Wells (<email address hidden>)
Branch: 15.04_STABLE

commit bfddcf285519e1d85be14c9547098f5b2d44d9ce
Author: Robert Lyon <email address hidden>
Date: Mon Jul 6 09:39:44 2015 +1200

Bug 1471604: Terms & Conditions not displaying on register page

If there are more than one institution to choose from as the div
container 'termscontainer' is not present on page.

Change-Id: I5a7e03ff4bd0f8a5bcd933d37bbf81ca441cbf92
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/4919
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/a1f7465a9faf95d3d9a9b0af6514519c38f1bc05
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit a1f7465a9faf95d3d9a9b0af6514519c38f1bc05
Author: Robert Lyon <email address hidden>
Date: Mon Jul 6 09:39:44 2015 +1200

Bug 1471604: Terms & Conditions not displaying on register page

If there are more than one institution to choose from as the div
container 'termscontainer' is not present on page.

Change-Id: I5a7e03ff4bd0f8a5bcd933d37bbf81ca441cbf92
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.