Mahara

Help links should include the form element they refer to in their alt text

Bug #1482448 reported by Jono M
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Jono M
Mahara 15.10.0
16.04
Fix Released
Low
Unassigned
Mahara 16.04.0

Bug Description

Many form elements in Mahara have blue "help" icons beside them, which pop up a dialog when clicked. These do currently include the accessible text "Help", but it is sometimes ambiguous to screen reader users which form element they refer to. It would be good to include the label of the element in the help text, eg. "Help for Auto-add users"

Affects latest master

Jono M (jonom)
Changed in mahara:
status: Confirmed → In Progress
assignee: nobody → Jono Mingard (mingard)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5490

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5490
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/d4013947f4777323aa488c64546fb316247974ee
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit d4013947f4777323aa488c64546fb316247974ee
Author: Jono Mingard <email address hidden>
Date: Fri Sep 11 15:00:36 2015 +1200

Add form element title to help icon accessible text (Bug #1482448)

Other help links (eg. for page titles) still don't include titles,
but it's not nearly as important for them

behatnotneeded

Change-Id: I5645818908daf3bc2671c779a3d14e78075d83ae

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5517

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5517
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/95825b5da7375a7f7817c3237a4a3846bb07a6dc
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit 95825b5da7375a7f7817c3237a4a3846bb07a6dc
Author: Jono Mingard <email address hidden>
Date: Fri Sep 11 15:00:36 2015 +1200

Add form element title to help icon accessible text (Bug #1482448)

Other help links (eg. for page titles) still don't include titles,
but it's not nearly as important for them

behatnotneeded

Change-Id: I5645818908daf3bc2671c779a3d14e78075d83ae
(cherry picked from commit d4013947f4777323aa488c64546fb316247974ee)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5589

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5589
Committed: https://git.mahara.org/mahara/mahara/commit/9a2d21fa171008f48cf257f1f702c85933f23778
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 9a2d21fa171008f48cf257f1f702c85933f23778
Author: Robert Lyon <email address hidden>
Date: Thu Oct 22 16:53:26 2015 +1300

Bug 1482448: Check element has title attribute

Before trying to pass it to get_help_icon()

Fieldset elements don't need titles but can have help icons

behatnotneeded

Change-Id: Ib37797514f9173cab9b172fdd4f0d88034b9373a
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5638

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5638
Committed: https://git.mahara.org/mahara/mahara/commit/82b1bda65d8b2dac39abfffc283fd7254aefb5d1
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit 82b1bda65d8b2dac39abfffc283fd7254aefb5d1
Author: Robert Lyon <email address hidden>
Date: Thu Oct 22 16:53:26 2015 +1300

Bug 1482448: Check element has title attribute

Before trying to pass it to get_help_icon()

Fieldset elements don't need titles but can have help icons

behatnotneeded

Change-Id: Ib37797514f9173cab9b172fdd4f0d88034b9373a
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 9a2d21fa171008f48cf257f1f702c85933f23778)

Kristina Hoeppner (kris-hoeppner)
no longer affects: mahara/15.10
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.