Mahara

Dropdown menus are no longer keyboard-accessible

Bug #1482455 reported by Jono M
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Jono M
Mahara 15.10.0
15.10
Fix Released
Undecided
Unassigned

Bug Description

With the introduction of the bootstrap theme, the old JavaScript for making the dropdown navigation keyboard accessible no longer seems to work. Hopefully that's just because the menus now use different class names, so the same script (js/dropdown-nav.js) could be updated with those new classes. In any case, this needs to be fixed, since the dropdown menus are not at all accessible without this feature.

Affects latest master

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5090

Jono M (jonom)
Changed in mahara:
assignee: nobody → Jono Mingard (mingard)
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5090
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/4f5eff808ab083532bf4b4aa857eff270b036999
Submitter: Jono Mingard (<email address hidden>)
Branch: master

commit 4f5eff808ab083532bf4b4aa857eff270b036999
Author: Jono Mingard <email address hidden>
Date: Thu Aug 13 14:30:02 2015 +1200

Update dropdown nav keyboard controls for Bootstrap theme (Bug #1482455)

Dropdown menus now show when they have the 'open' class as well as
on hover, and the dropdown navigation script has been updated to use
the new menu bar classes (and with better code style)

behatnotneeded: doesn't seem to be any good way to fire specific
keyboard events at the page in order to test this

Change-Id: I1bf17183c0510914f16ada7299cfddd6ce29e907
Signed-off-by: Jono Mingard <email address hidden>

Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.