Mahara

Add row button in custom layout creator should have focus management

Bug #1482480 reported by Jono M
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Jono M
Mahara 15.10.0
15.10
Fix Released
Undecided
Unassigned

Bug Description

When creating a custom layout, the "Add a row" button creates a new row editor with JavaScript. To make sense for screen reader users, it should also focus the new row - probably the "Number of columns" combo box since it's the first control in the new form.

Affects latest master

Jono M (jonom)
Changed in mahara:
milestone: none → 15.10.0
Jono M (jonom)
summary: - Add row button in custom layout creator should have focus management
+ Adding custom layout does not set up input properly
summary: - Adding custom layout does not set up input properly
+ Add row button in custom layout creator should have focus management
Jono M (jonom)
Changed in mahara:
status: Confirmed → In Progress
assignee: nobody → Jono Mingard (mingard)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5386

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5386
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/9ca6dba031d66cb55c6e8cdc21b231c5d2b78284
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 9ca6dba031d66cb55c6e8cdc21b231c5d2b78284
Author: Jono Mingard <email address hidden>
Date: Mon Sep 28 18:18:58 2015 +1300

Focus management when adding rows to custom layout (Bug #1482480)

Also makes sure that the 'for' attribute of the new <select> labels
is set up properly

behatnotneeded

Change-Id: I9b8de6fb99fe912cb6a09dc2278942731110fcc1

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5495

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5495
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/e039baf146b7f63b13c203c6a97aa176ee52fa10
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit e039baf146b7f63b13c203c6a97aa176ee52fa10
Author: Jono Mingard <email address hidden>
Date: Mon Sep 28 18:18:58 2015 +1300

Focus management when adding rows to custom layout (Bug #1482480)

Also makes sure that the 'for' attribute of the new <select> labels
is set up properly

behatnotneeded

Change-Id: I9b8de6fb99fe912cb6a09dc2278942731110fcc1
(cherry picked from commit 9ca6dba031d66cb55c6e8cdc21b231c5d2b78284)

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.