Hour and minute combo boxes in date picker have no labels

Bug #1482492 reported by Jono M
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Jono M
15.10
Fix Released
Undecided
Unassigned

Bug Description

In the date picker used on the Group settings page, the first three combo boxes (year, month, day) have screen reader accessible labels describing the control. However, the last two (hour and minute) have no such label, and screen reader users would find it hard to figure out what these are for. The same sort of label should also be added for these combo boxes.

Affects latest master

Jono M (jonom)
Changed in mahara:
status: Confirmed → In Progress
assignee: nobody → Jono Mingard (mingard)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5093

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5093
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/7f0cd1a606942f2162842e1e3baa87be03fb48af
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 7f0cd1a606942f2162842e1e3baa87be03fb48af
Author: Jono Mingard <email address hidden>
Date: Thu Aug 13 16:27:59 2015 +1200

Add accessible labels to date picker combo boxes (Bug #1482492)

Added screen-reader-accessible labels to the hour/minute combo boxes
in this date picker, like the ones already on the year/month/day controls

behatnotneeded

Change-Id: I69adef047c91b5dcf3553db21923c47a9f625b62
Signed-off-by: Jono Mingard <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
milestone: none → 15.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5140

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.