Mahara

Prompt for new stat data after upgrade needs a 'no thanks' option

Bug #1486813 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon
Mahara 15.10.0
1.10
Fix Released
High
Unassigned
Mahara 1.10.7
1.9
Fix Released
High
Unassigned
Mahara 1.9.9
15.04
Fix Released
High
Unassigned
Mahara 15.04.4

Bug Description

With the patch for Bug 1450334 an admin on upgrade is redirected to the Register site page.

If they navigate away rather than deciding to register the check 'new_registration_policy' is still active.

This means that if the user upgrades again (or upgrades a plugin ) they are again redirected to the register site page.

We need to alter the register site form so that there is a 'no thanks' (cancel) option that updates the 'new_registration_policy' to false as well otherwise it will get a bit annoying for those not wanting to register their site.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5210

Revision history for this message
Robert Lyon (robertl-9) wrote :

I've added a 'cancel' button to the register form - as I'm still not sure what the best text for the form cancel option is.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5210
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/a48767e597aa3b6be1019597b328c3b8f01847cb
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit a48767e597aa3b6be1019597b328c3b8f01847cb
Author: Robert Lyon <email address hidden>
Date: Fri Sep 4 10:28:36 2015 +1200

Bug 1486813: Stop redirect to 'register site' page after each upgrade

By adding a cancel option to the register site form that clears the
new_registration_policy config setting.

behatnotneeded

Change-Id: I65cf7239b9fe021d17be387eeb8bfda9547c5032
Signed-off-by: Robert Lyon <email address hidden>

Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/5420

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "1.10_STABLE" branch: https://reviews.mahara.org/5421

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "1.9_STABLE" branch: https://reviews.mahara.org/5422

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5422
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/824c1dbbec1e8f0419f94fa3596196871ca7317f
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.9_STABLE

commit 824c1dbbec1e8f0419f94fa3596196871ca7317f
Author: Robert Lyon <email address hidden>
Date: Fri Sep 4 10:28:36 2015 +1200

Bug 1486813: Stop redirect to 'register site' page after each upgrade

By adding a cancel option to the register site form that clears the
new_registration_policy config setting.

behatnotneeded

Change-Id: I65cf7239b9fe021d17be387eeb8bfda9547c5032
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/5421
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/297b6003cb2a92a817fa64cbdaa98b6c5ca39ebd
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.10_STABLE

commit 297b6003cb2a92a817fa64cbdaa98b6c5ca39ebd
Author: Robert Lyon <email address hidden>
Date: Fri Sep 4 10:28:36 2015 +1200

Bug 1486813: Stop redirect to 'register site' page after each upgrade

By adding a cancel option to the register site form that clears the
new_registration_policy config setting.

behatnotneeded

Change-Id: I65cf7239b9fe021d17be387eeb8bfda9547c5032
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/5420
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/48c1e54ea275d679a2228d86a8994562a55d91ff
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit 48c1e54ea275d679a2228d86a8994562a55d91ff
Author: Robert Lyon <email address hidden>
Date: Fri Sep 4 10:28:36 2015 +1200

Bug 1486813: Stop redirect to 'register site' page after each upgrade

By adding a cancel option to the register site form that clears the
new_registration_policy config setting.

behatnotneeded

Change-Id: I65cf7239b9fe021d17be387eeb8bfda9547c5032
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
no longer affects: mahara/15.10
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.