Mahara

Uploading an image in TinyMCE in a journal entry doesn't work

Bug #1487222 reported by Kristina Hoeppner
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon
Mahara 15.10.0
15.10
Fix Released
Undecided
Unassigned

Bug Description

Mahara master 15.10dev latest pull from today

Uploading an image via TinyMCE into a journal entry does not work. It works fine for the journal description itself, but not in a journal entry.

To replicate:

1. Create a new journal entry.
2. In the journal entry TinyMCE click the image button.
3. Select an image from your computer and try to upload it.

Expected result: The image is uploaded.
Actual result: The "Loading..." icon is spinning in the background and nothing really happens.

Tested on Ubuntu 14.04, latest Firefox

Robert Lyon (robertl-9)
Changed in mahara:
assignee: nobody → Robert Lyon (robertl-9)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5163

Robert Lyon (robertl-9)
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5163
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/2b224d46178eafcb59327f4a753f8de9b6ed44c3
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 2b224d46178eafcb59327f4a753f8de9b6ed44c3
Author: Robert Lyon <email address hidden>
Date: Mon Aug 24 12:27:48 2015 +1200

Bug 1487222: Loading spinner problem with TinyMCE imagebrowser

behatnotneeded: is a style change

When you submit the form after uploading an image it removes the form
completely from the DOM so that the functions formStopProcessing() and
processingStop() never get to trigger.

I've added a processingStop() to the imagebrowser code directly - this
should be fine as mahara.js is called on every page so the function
will be presesnt.

Change-Id: I2ef6b44885e75c6f032557adacd920efbf4b1aa2
Signed-off-by: Robert Lyon <email address hidden>

Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.