Mahara

Focus management needed in Resume forms

Bug #1487294 reported by Jono M
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Jono M
Mahara 15.10.0
15.10
Fix Released
Undecided
Unassigned

Bug Description

With the new Bootstrap theme, forms to add content to the Resume (eg. under Education and employment / Achievements) are displayed inline when the "Add" button is clicked. These need to have focus management so that it is clear to screen reader users what has happened. In particular:

- When opening the form, focus should be set to the first form control
- When the "Save" button is clicked, focus should be set to the new row in the table
- Moving rows up and down should also have sensible focus management

Affects latest master

See original description
Jono M (jonom)
description: updated
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5186

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/5187

Jono M (jonom)
Changed in mahara:
status: Confirmed → In Progress
assignee: nobody → Jono Mingard (mingard)
Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
status: Fix Committed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5186
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/0966ffa8efdbc2f9c67018b07de510ad7f370d45
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 0966ffa8efdbc2f9c67018b07de510ad7f370d45
Author: Jono Mingard <email address hidden>
Date: Fri Aug 28 14:04:43 2015 +1200

Focus management for composite Resume tables (Bug #1487294)

This only addresses the parts of the bug report specifically
related to the table (ie. focusing the new row on add and
focusing the moved row on move up/down) since they're related
to TableRenderer rather than Bootstrap

behatnotneeded

Change-Id: Iefe34dff56d8d38f98f9b0f85b08843e6e7d898a

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5496

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5496
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/12a8d085814e9c244d1f5ad9fe01a59274b0bb8e
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit 12a8d085814e9c244d1f5ad9fe01a59274b0bb8e
Author: Jono Mingard <email address hidden>
Date: Fri Aug 28 14:04:43 2015 +1200

Focus management for composite Resume tables (Bug #1487294)

This only addresses the parts of the bug report specifically
related to the table (ie. focusing the new row on add and
focusing the moved row on move up/down) since they're related
to TableRenderer rather than Bootstrap

behatnotneeded

Change-Id: Iefe34dff56d8d38f98f9b0f85b08843e6e7d898a
(cherry picked from commit 0966ffa8efdbc2f9c67018b07de510ad7f370d45)

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.