Mahara

Selected tab not indicated in "Shared by me"

Bug #1487301 reported by Jono M
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Jono M
Mahara 15.10.0
15.10
Fix Released
Undecided
Unassigned

Bug Description

In the new Bootstrap theme, the tabs on the "Shared by me" page use ARIA attributes, but both are marked as deselected on page load. The selected tab ("Collections") should have aria-selected="true".

Affects latest master

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5180

Jono M (jonom)
Changed in mahara:
status: Confirmed → In Progress
assignee: nobody → Jono Mingard (mingard)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5180
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/39d8c5060aa6ee649c5b565d4dfcfa78e16e6920
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 39d8c5060aa6ee649c5b565d4dfcfa78e16e6920
Author: Jono Mingard <email address hidden>
Date: Thu Aug 27 17:14:53 2015 +1200

Add aria-selected to default tab in "Shared by me" (Bug #1487301)

Since "Collections" is selected by default its ARIA attributes
should reflect that.

behatnotneeded

Change-Id: I64885530585ea3fb400949c99992139bf828d971

Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.