Sort submitted pages "Most recently submitted" doesn't work

Hello Gordon,

Thank you for your report. I don't see the sort order change for "Submitted pages". But I do see "Shared pages" change their sort order. Do you have a problem there as well?

Is your second query for shared or submitted pages or both? We'd need to set up a new wishlist item for that.

Cheers
Kristina

Hello Kristina,

I honestly didn't notice the text refered to submitted pages rather than shared - it was shared pages I was trying to change the sort order for, which might explain why it didn't work - but if that's the case it then flags this as a needed feature rather than a bug!
Regarding the second comment - it would be useful to be able to sort both shared and submitted pages by 'most recently added'.
I'll add a new wishlist request specifically for that.

Regards, Gordon.

Hi Gordon,

Can you please re-test with the difference between shared and submitted pages? As I mentioned in my previous comment, the sort order changed for "Shared pages" but not for "Submitted pages". The wording for both "most recent" options is slightly different. Shared pages can be updated and thus that's the sort order to be displayed whereas submitted pages can't be updated and thus can only be sorted alphabetically or according to their submission date.

I updated your wishlist item bug #1490862 accordingly.

Cheers
Kristina

Hi Kristina,
Sorry for the delay - start of term!

I've re-tested based on your comments, and have discovered a doozy of a knock-on effect - which either confuses or clarifies the bug. I'll outline the testing steps as I carried them out to discover what's actually happening - though I can't say how the effect is being caused.

Sort shared pages & collections by "most recently updated"
Display within the block reads "Collections shared with this group"
Result - order changes from what was displayed under alphabetical. No date information is displayed so can only presume it is chronological

Sort submitted pages and collections by "most recently updated"
Display within the block reads "Submissions to this group"
Result - the order doesn't change from alphabetical
Dates show 'time of submission' and are not chronologically ordered
eg 1st four items in sequence display following submission dates 20 Aug 2.12pm, 20 Aug 8.00pm, 21st Aug 12.26pm, 19 Aug 1.42pm, and the titles are alphabetical Brandon, Caitlin, Mansour, Matthew.

I THEN discovered that if I switch "Sort shared pages and collections" back to Alphabetical while leaving sumbitted pages as 'most recently updated' the "Submissions to this group" order then changes - and this time does display chronologically. So it appears that sorting by date in the SHARED sort menu has an affect on the display of the SUBMITTED sort order.

Regards, Gordon.

Hi Gordon,

Can you please check this issue in 15.10 RC?

Thanks,
Son Nguyen

Patch for "master" branch: https://reviews.mahara.org/5475

I added a patch for showing created/updated time for shared pages to a group

For testing, here is a guide for verify the list of shared pages

1. Create a group
2. Add some users to the group
3. Login as a group member, create some pages and shared them to the group
4. Login as a group owner, edit the group homepage, reconfigure the "Group pages" block, select the sort type of shared pages
5. Save the group home page

Make sure the list of shared pages is correctly sorted.

The patch that Son provided doesn't fix the problem but changes something else. I created a separate bug for it at bug #1506617 so we don't mix the two things up.

Hi Gordon,

Submitted collections are sorted correctly for me in 15.10. So we'll just keep the issue open for 15.04.

Cheers
Kristina

Reviewed: https://reviews.mahara.org/5475
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/d2a4f3862b62453eb68bf249734c4ca828779f78
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit d2a4f3862b62453eb68bf249734c4ca828779f78
Author: Son Nguyen <email address hidden>
Date: Thu Oct 8 09:52:52 2015 +1300

Show created or updated time for shared pages to a group. Bug 1490569.

Change-Id: Ie30deb73078269be4b3f0e1414e1ea4cb70dc917

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5576

Reviewed: https://reviews.mahara.org/5576
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/04095d7e2e65057719b3cdd123fd9266e2a52531
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit 04095d7e2e65057719b3cdd123fd9266e2a52531
Author: Son Nguyen <email address hidden>
Date: Thu Oct 8 09:52:52 2015 +1300

Show created or updated time for shared pages to a group. Bug 1490569.

Change-Id: Ie30deb73078269be4b3f0e1414e1ea4cb70dc917
(cherry picked from commit d2a4f3862b62453eb68bf249734c4ca828779f78)

This is now fixed in both 15.04 and 15.10, BUT the group pages block does not update when you click "Save" - you need to refresh the page before the new sort order takes effect.

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/5621

Patch for "master" branch: https://reviews.mahara.org/5622

Reviewed: https://reviews.mahara.org/5621
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/da49f615cc1888a04aec029e6bec83da216ce378
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit da49f615cc1888a04aec029e6bec83da216ce378
Author: Robert Lyon <email address hidden>
Date: Tue Oct 27 10:35:58 2015 +1300

Bug 1490569: Saving the instance before returning the data

The $instance->configdata is different to the $bi->configdata due to
the $instance->configdata being the before save data so it would
return the data to display as the pre configform save state.

behatnotneeded

Change-Id: I015a062b23421df740b09dbbc6a715fa306126e4
Signed-off-by: Robert Lyon <email address hidden>

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5630

Reviewed: https://reviews.mahara.org/5630
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/3aa7c1b68ed911b9163ee1b3384815425233282e
Submitter: Son Nguyen (<email address hidden>)
Branch: 15.10_STABLE

commit 3aa7c1b68ed911b9163ee1b3384815425233282e
Author: Robert Lyon <email address hidden>
Date: Tue Oct 27 10:35:58 2015 +1300

Bug 1490569: Saving the instance before returning the data

The $instance->configdata is different to the $bi->configdata due to
the $instance->configdata being the before save data so it would
return the data to display as the pre configform save state.

behatnotneeded

Change-Id: I015a062b23421df740b09dbbc6a715fa306126e4
Signed-off-by: Robert Lyon <email address hidden>

Reviewed: https://reviews.mahara.org/5622
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/06a358a186737cee27eeefd887801b0a72dea11a
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 06a358a186737cee27eeefd887801b0a72dea11a
Author: Robert Lyon <email address hidden>
Date: Tue Oct 27 10:35:58 2015 +1300

Bug 1490569: Saving the instance before returning the data

The $instance->configdata is different to the $bi->configdata due to
the $instance->configdata being the before save data so it would
return the data to display as the pre configform save state.

behatnotneeded

Change-Id: I015a062b23421df740b09dbbc6a715fa306126e4
Signed-off-by: Robert Lyon <email address hidden>