LightPath Dignostics framework on PowerNV platform

Bug #1494735 reported by bugproxy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
linux (Ubuntu)
Fix Released
High
Tim Gardner
Wily
Fix Released
High
Tim Gardner

Bug Description

== Comment: #0 - VASANT HEGDE <email address hidden> - 2015-09-11 05:56:57 ==
IBM x, i and p systems have Service indicators (LED) that help identify components (Guiding Light) and also to indicate a component in error (Light Path). Currently, Linux only has a couple of commands that cater to LightPath services, but not close to what is expected. The work involved is to deliver a LightPath framework that will help customer to identify a hardware component in error.

commit 8a8d91817aec6b9ca7a289891f9e6f721100ec09
Author: Anshuman Khandual <email address hidden>
Date: Wed Aug 19 22:19:52 2015 +0530

    powerpc/powernv: Add OPAL interfaces for accessing and modifying system LED states

    This patch registers the following two new OPAL interfaces calls
    for the platform LED subsystem. With the help of these new OPAL calls,
    the kernel will be able to get or set the state of various individual
    LEDs on the system at any given location code which is passed through
    the LED specific device tree nodes.

        (1) OPAL_LEDS_GET_INDICATOR opal_leds_get_ind
        (2) OPAL_LEDS_SET_INDICATOR opal_leds_set_ind

    Signed-off-by: Anshuman Khandual <email address hidden>
    Signed-off-by: Vasant Hegde <email address hidden>
    Acked-by: Stewart Smith <email address hidden>
    Tested-by: Stewart Smith <email address hidden>

commit c159b5968ec9d3cbf16802189b29eb0ec17ae4d8
Author: Vasant Hegde <email address hidden>
Date: Wed Aug 19 22:19:53 2015 +0530

    powerpc/powernv: Create LED platform device

    This patch adds platform devices for leds. Also export LED related
    OPAL API's so that led driver can use these APIs.

    Signed-off-by: Vasant Hegde <email address hidden>
    Acked-by: Benjamin Herrenschmidt <email address hidden>
    Signed-off-by: Michael Ellerman <email address hidden>

commit 84ad6e5cd3e8b365c893f31787864cae5500610b
Author: Vasant Hegde <email address hidden>
Date: Wed Aug 19 22:19:54 2015 +0530

    leds/powernv: Add driver for PowerNV platform

    This patch implements LED driver for PowerNV platform using the existing
    generic LED class framework.

commit 5d53be7d8c7ccf8eec1ce66c6b3573c01d16b755
Author: Michael Ellerman <email address hidden>
Date: Sat Aug 22 09:33:55 2015 +1000

    powerpc/powernv: Fix mis-merge of OPAL support for LEDS driver

    When I merged the OPAL support for the powernv LEDS driver I missed a
    hunk.

    This is slightly modified from the original patch, as the original added
    code to opal-api.h which is not in the skiboot version, which is
    discouraged.

    Instead those values are moved into the driver, which is the only place
    they are used.

commit d690740f22f6520873f96e66aae7119ec2215755
Author: Vasant Hegde <email address hidden>
Date: Thu Aug 27 11:34:10 2015 +0530

    powerpc/powernv: Enable LEDS support

    Commit 84ad6e5c added LEDS support for PowerNV platform. Lets
    update ppc64_defconfig to pick LEDS driver.

    PowerNV LEDS driver looks for "/ibm,opal/leds" node in device
    tree and loads if this node exists. Hence added it as 'm'.

    Also note that powernv LEDS driver needs NEW_LEDS and LEDS_CLASS
    as well. Hence added them to config file.

    mpe: Also add them to pseries_defconfig, which is currently also used
    for powernv systems.

    Suggested-by: Michael Ellerman <email address hidden>
    Signed-off-by: Vasant Hegde <email address hidden>
    Cc: Stewart Smith <email address hidden>
    Signed-off-by: Michael Ellerman <email address hidden>

-Vasant

== Comment: #1 - VASANT HEGDE <email address hidden> - 2015-09-11 05:58:20 ==
All these patches went into current merge window (4.3).. Let me know if you want me to backport those patches.

-Vasant

bugproxy (bugproxy)
tags: added: architecture-ppc64 bugnameltc-130256 severity-high targetmilestone-inin1510
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

Thank you for taking the time to report this bug and helping to make Ubuntu better. It seems that your bug report is not filed about a specific source package though, rather it is just filed against Ubuntu in general. It is important that bug reports be filed about source packages so that people interested in the package can find the bugs about it. You can find some hints about determining what package your bug might be about at https://wiki.ubuntu.com/Bugs/FindRightPackage. You might also ask for help in the #ubuntu-bugs irc channel on Freenode.

To change the source package that this bug is filed about visit https://bugs.launchpad.net/ubuntu/+bug/1494735/+editstatus and add the package name in the text box next to the word Package.

[This is an automated message. I apologize if it reached you inappropriately; please just reply to this message indicating so.]

tags: added: bot-comment
Changed in ubuntu:
assignee: nobody → Taco Screen team (taco-screen-team)
bugproxy (bugproxy)
tags: added: targetmilestone-inin1604
removed: targetmilestone-inin1510
affects: ubuntu → linux (Ubuntu)
Changed in linux (Ubuntu):
assignee: Taco Screen team (taco-screen-team) → Canonical Kernel Team (canonical-kernel-team)
importance: Undecided → High
status: New → Triaged
Tim Gardner (timg-tpi)
Changed in linux (Ubuntu Wily):
assignee: Canonical Kernel Team (canonical-kernel-team) → Tim Gardner (timg-tpi)
status: Triaged → In Progress
Revision history for this message
Tim Gardner (timg-tpi) wrote :

powerpc/powernv: Enable LEDS support
powerpc/powernv: Fix mis-merge of OPAL support for LEDS driver
leds/powernv: Add driver for PowerNV platform
powerpc/powernv: Create LED platform device
powerpc/powernv: Add OPAL interfaces for accessing and modifying system LED states
UBUNTU: [Config] CONFIG_LEDS_POWERNV=m

Changed in linux (Ubuntu Wily):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux - 4.2.0-10.12

---------------
linux (4.2.0-10.12) wily; urgency=low

  [ Tim Gardner ]

  * Release Tracking Bug
    - LP: #1496109

  [ Paolo Pisati ]

  * [Config] armhf: ARM_KERNMEM_PERMS=y && DEBUG_RODATA=y

  [ Tim Gardner ]

  * [Config] CONFIG_LEDS_POWERNV=m
    - LP: #1494735

  [ Upstream Kernel Changes ]

  * intel_pstate: enable HWP per CPU
    - LP: #1494073
  * intel_pstate: Fix possible overflow complained by Coverity
    - LP: #1494073
  * intel_pstate: Add SKY-S support
    - LP: #1494073
  * powerpc/powernv: Add OPAL interfaces for accessing and modifying system
    LED states
    - LP: #1494735
  * powerpc/powernv: Create LED platform device
    - LP: #1494735
  * leds/powernv: Add driver for PowerNV platform
    - LP: #1494735
  * powerpc/powernv: Fix mis-merge of OPAL support for LEDS driver
    - LP: #1494735
  * powerpc/powernv: Enable LEDS support
    - LP: #1494735

 -- Tim Gardner <email address hidden> Tue, 15 Sep 2015 08:29:16 -0600

Changed in linux (Ubuntu Wily):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.