Mahara

Problem with scaling in flowplayer

Bug #1496910 reported by Marc-Andre Gaudreau
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Aaron Wells
Mahara 15.10.0
1.10
Fix Released
Medium
Aaron Wells
Mahara 1.10.7
1.9
Fix Released
Medium
Aaron Wells
Mahara 1.9.9
15.04
Fix Released
Medium
Aaron Wells
Mahara 15.04.4
15.10
Fix Released
Medium
Aaron Wells
Mahara 15.10.0

Bug Description

When I create a page with "embedded media" (edit page > media > embedded media) and chose a video file, it is displayed in flowplayer with the scaling parameter set to "scale". This "deforms" the original video by changing the aspect ratio (for example, a 16:9 video is "scaled" to fit the box of a 500x300 embedded media (not 16:9).

I corrected this locally by putting "scaling: 'orig'" in "artefact/file/blocktype/internalmedia/lib.php" in the flowplayer specifications.

Keep up the good job! :)

Mahara version : 15.04.3
Operating system : Linux
Database : MariaDB

Aaron Wells (u-aaronw)
Changed in mahara:
assignee: nobody → Aaron Wells (u-aaronw)
Revision history for this message
Aaron Wells (u-aaronw) wrote :

Problem confirmed. To replicate:

1. Download this sample 16:9 public domain video from archive.org: https://archive.org/details/CEP427 (or any other 16:9 file)
2. Upload the 16:9 video into your file area in Mahara
3. Put the video into an "Embedded media" block in Mahara

Expected result: The video displays at its native 16:9 resolution
Actual result: The video is distored to a different resolution

Revision history for this message
Aaron Wells (u-aaronw) wrote :

Note to testers: the file I linked to is a ".mp4" file. By default the Embedded Media block only supports FLV & MP3 files. So on a clean Mahara install, you'll also need to go to Extensions -> Plugin Administration -> blocktype: file/internalmedia, and turn on "MP4 video file" as an option.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5333

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5333
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/caa62e2eaf819bed095c6d50b753c18922e64873
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit caa62e2eaf819bed095c6d50b753c18922e64873
Author: Marc-Andre Gaudrea <email address hidden>
Date: Wed Sep 23 13:01:50 2015 +1200

Tell Flowplayer to preserve video's aspect ratio

Bug 1496910

behatnotneeded: Has only a visual impact, can't be tested by Behat

Change-Id: I2b531c92ed46ad3b364206161ff6851314749573

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/5345

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "1.10_STABLE" branch: https://reviews.mahara.org/5346

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5345
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/895d53c6afc32939f732d153e0ea2c35d5ae5946
Submitter: Aaron Wells (<email address hidden>)
Branch: 15.04_STABLE

commit 895d53c6afc32939f732d153e0ea2c35d5ae5946
Author: Marc-Andre Gaudrea <email address hidden>
Date: Wed Sep 23 13:01:50 2015 +1200

Tell Flowplayer to preserve video's aspect ratio

Bug 1496910

behatnotneeded: Has only a visual impact, can't be tested by Behat

Change-Id: I2b531c92ed46ad3b364206161ff6851314749573
(cherry picked from commit caa62e2eaf819bed095c6d50b753c18922e64873)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/5346
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/b463d09003890ce7290e99d44019cae99c3f432a
Submitter: Aaron Wells (<email address hidden>)
Branch: 1.10_STABLE

commit b463d09003890ce7290e99d44019cae99c3f432a
Author: Marc-Andre Gaudrea <email address hidden>
Date: Wed Sep 23 13:01:50 2015 +1200

Tell Flowplayer to preserve video's aspect ratio

Bug 1496910

behatnotneeded: Has only a visual impact, can't be tested by Behat

Change-Id: I2b531c92ed46ad3b364206161ff6851314749573
(cherry picked from commit caa62e2eaf819bed095c6d50b753c18922e64873)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "1.9_STABLE" branch: https://reviews.mahara.org/5347

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5347
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/b09f156c23e42b7bec05d7ad8dc9326f7d7abc27
Submitter: Aaron Wells (<email address hidden>)
Branch: 1.9_STABLE

commit b09f156c23e42b7bec05d7ad8dc9326f7d7abc27
Author: Marc-Andre Gaudrea <email address hidden>
Date: Wed Sep 23 13:01:50 2015 +1200

Tell Flowplayer to preserve video's aspect ratio

Bug 1496910

behatnotneeded: Has only a visual impact, can't be tested by Behat

Change-Id: I2b531c92ed46ad3b364206161ff6851314749573
(cherry picked from commit caa62e2eaf819bed095c6d50b753c18922e64873)
(cherry picked from commit b463d09003890ce7290e99d44019cae99c3f432a)

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.