Mahara

remove old session files doesn't work with adapted sessionpath

Bug #1500774 reported by Manuel Gogl
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Unassigned
Mahara 15.10.0
1.10
Fix Released
High
Unassigned
Mahara 1.10.7
1.9
Fix Released
High
Unassigned
Mahara 1.9.9
15.04
Fix Released
High
Unassigned
Mahara 15.04.4
15.10
Fix Released
High
Unassigned
Mahara 15.10.0

Bug Description

auth/lib.php is using
$basedir = get_config('dataroot') . 'sessions/';
for trying to remove the old session files.

If there is a different session path set, mahara does not notice this adaptation.

Following modification is fixing the problem:

auth/lib.php:
function auth_remove_old_session_files() {
    $basedir = get_config('sessionpath');

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5403

Revision history for this message
Robert Lyon (robertl-9) wrote :

Hi Manuel,

Thank you for your bug report - I've added your fix to our review system
https://reviews.mahara.org/#/c/5403/

Once it passes that step it will be merged in.

Cheers

Robert

Changed in mahara:
status: New → In Progress
milestone: none → 15.10.0
importance: Undecided → High
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5403
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/4deca62129f7d6c0f2a8f57aa5e63b95e0848d29
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 4deca62129f7d6c0f2a8f57aa5e63b95e0848d29
Author: Manuel Gogl <email address hidden>
Date: Wed Sep 30 08:37:29 2015 +1300

Bug 1500774: Use correct path for deleting old sessions

behatnotneeded: dealing with deletign files from dataroot

Change-Id: I0c6f2ef1b04b8ac4beef2daef2459b619db9a9ed
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/5445

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "1.10_STABLE" branch: https://reviews.mahara.org/5446

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "1.9_STABLE" branch: https://reviews.mahara.org/5447

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5447
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/7062f357add00f3b90bb00eafb7994e729d7230a
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.9_STABLE

commit 7062f357add00f3b90bb00eafb7994e729d7230a
Author: Manuel Gogl <email address hidden>
Date: Wed Sep 30 08:37:29 2015 +1300

Bug 1500774: Use correct path for deleting old sessions

behatnotneeded: dealing with deletign files from dataroot

Change-Id: I0c6f2ef1b04b8ac4beef2daef2459b619db9a9ed
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 4deca62129f7d6c0f2a8f57aa5e63b95e0848d29)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/5446
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/c810999b9d10b03de05ca67bb2c3d8591c4d8d94
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.10_STABLE

commit c810999b9d10b03de05ca67bb2c3d8591c4d8d94
Author: Manuel Gogl <email address hidden>
Date: Wed Sep 30 08:37:29 2015 +1300

Bug 1500774: Use correct path for deleting old sessions

behatnotneeded: dealing with deletign files from dataroot

Change-Id: I0c6f2ef1b04b8ac4beef2daef2459b619db9a9ed
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 4deca62129f7d6c0f2a8f57aa5e63b95e0848d29)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/5445
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/b33100b4c87d26165c31ca231750500d7f2fae01
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit b33100b4c87d26165c31ca231750500d7f2fae01
Author: Manuel Gogl <email address hidden>
Date: Wed Sep 30 08:37:29 2015 +1300

Bug 1500774: Use correct path for deleting old sessions

behatnotneeded: dealing with deletign files from dataroot

Change-Id: I0c6f2ef1b04b8ac4beef2daef2459b619db9a9ed
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 4deca62129f7d6c0f2a8f57aa5e63b95e0848d29)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5596

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5596
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/d1b6145f31caee8ca33ea408791e42e7b2094d18
Submitter: Aaron Wells (<email address hidden>)
Branch: 15.10_STABLE

commit d1b6145f31caee8ca33ea408791e42e7b2094d18
Author: Manuel Gogl <email address hidden>
Date: Wed Sep 30 08:37:29 2015 +1300

Bug 1500774: Use correct path for deleting old sessions

behatnotneeded: dealing with deletign files from dataroot

Change-Id: I0c6f2ef1b04b8ac4beef2daef2459b619db9a9ed
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 4deca62129f7d6c0f2a8f57aa5e63b95e0848d29)

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.