Mahara

Position of the contextual help block is incorrect

Bug #1501059 reported by Son Nguyen
24
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Unassigned
Mahara 15.10.0
15.10
Fix Released
Undecided
Unassigned

Bug Description

Version: master, 15.10

Browsers: FF, Chrome

The possition of the contextual help box is not correct in some pages like

 - htdocs/admin/users/institutions.php
 - htdocs/account/index.php

Revision history for this message
Son Nguyen (ngson2000) wrote :
Robert Lyon (robertl-9)
Changed in mahara:
importance: Undecided → High
milestone: none → 15.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5461

Revision history for this message
Robert Lyon (robertl-9) wrote :

This needs to be sorted out as some of the bigger help blocks are not able to be read and that is surely a regression.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5461
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/a74afc3018b336f5a2bb83b9f047dca5d7418524
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit a74afc3018b336f5a2bb83b9f047dca5d7418524
Author: Robert Lyon <email address hidden>
Date: Tue Oct 6 12:42:21 2015 +1300

Bug 1501059: Contextual help positioning wrong in some cases

If the 'i' link is in a span with css position:absolute the computed
position for the help box is incorrect.

Need to allow for this

behatnotneeded

Change-Id: I49dc225ae8f7dc5eabe5cab0f887b74758a6e51e
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5483

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5483
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/4cd90a28eb0eb8764de87fe352e6cfcbc691c991
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit 4cd90a28eb0eb8764de87fe352e6cfcbc691c991
Author: Robert Lyon <email address hidden>
Date: Tue Oct 6 12:42:21 2015 +1300

Bug 1501059: Contextual help positioning wrong in some cases

If the 'i' link is in a span with css position:absolute the computed
position for the help box is incorrect.

Need to allow for this

behatnotneeded

Change-Id: I49dc225ae8f7dc5eabe5cab0f887b74758a6e51e
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit a74afc3018b336f5a2bb83b9f047dca5d7418524)

Robert Lyon (robertl-9)
Changed in mahara:
status: Confirmed → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5503

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5503
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/4933019f45c7fbee4f7f09793c7ccb997503bf8f
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 4933019f45c7fbee4f7f09793c7ccb997503bf8f
Author: Jen Zajac <email address hidden>
Date: Mon Oct 12 11:26:51 2015 +1300

Bug 1501059 Fix help pop outs in forms

The previous patch for this didn't work for larger screens.

behatnotneeded

Change-Id: I7d88abbb5ca49dfcbbb45b82b817da26450d645e

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5512

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5512
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/7a1ca7a072d6f793ca70c6617ad2da89ae5b2645
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit 7a1ca7a072d6f793ca70c6617ad2da89ae5b2645
Author: Jen Zajac <email address hidden>
Date: Mon Oct 12 11:26:51 2015 +1300

Bug 1501059 Fix help pop outs in forms

The previous patch for this didn't work for larger screens.

behatnotneeded

Change-Id: I7d88abbb5ca49dfcbbb45b82b817da26450d645e
(cherry picked from commit 4933019f45c7fbee4f7f09793c7ccb997503bf8f)

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.