Mahara

All user to set their theme to site default

Bug #1501078 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Robert Lyon
Mahara 15.10.0
15.10
Fix Released
Undecided
Unassigned

Bug Description

When the $cfg->sitethemeprefs = true; is set one can choose to use a particular theme.

But they can't NOT choose a theme and just go with the site/institution default if they have already chosen.

Will add a patch to allow the ability to choose 'No theme selected'

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5404

Aaron Wells (u-aaronw)
Changed in mahara:
milestone: 15.10.1 → 15.10.0
importance: Medium → High
importance: High → Medium
milestone: 15.10.0 → 16.04.0
Revision history for this message
Charlie Amoah (charlie-catalyst) wrote :

IE and Firefox browsers are showing broken language strings on the landing page. Please see the attached screen shot.

Revision history for this message
Dean (deans) wrote :

I get the following errors when checking the patch in, going to the config.php file and adding $cfg->sitethemeprefs = true;

Then running http://127.0.0.1/mahara/htdocs/

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5404
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/6c757ae33a2b26bf0711faae55464ce70e1b1f04
Submitter: Jono Mingard (<email address hidden>)
Branch: master

commit 6c757ae33a2b26bf0711faae55464ce70e1b1f04
Author: Robert Lyon <email address hidden>
Date: Wed Sep 30 10:36:55 2015 +1300

Bug 1501078: Allow the setting of 'no theme'

In user account settings page

behatnotneeded

Change-Id: I9eb8f345054ece362635cf93f6455a0dc55dbe63
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5532

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5532
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/50580bac2d3e8aa295aa62d16c92701a24c6a94c
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit 50580bac2d3e8aa295aa62d16c92701a24c6a94c
Author: Robert Lyon <email address hidden>
Date: Wed Sep 30 10:36:55 2015 +1300

Bug 1501078: Allow the setting of 'no theme'

In user account settings page

behatnotneeded

Change-Id: I9eb8f345054ece362635cf93f6455a0dc55dbe63
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 6c757ae33a2b26bf0711faae55464ce70e1b1f04)

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
milestone: 16.04.0 → 15.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5540

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5540
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/c31c81c7711888bed3801d6a5f470824dcd21845
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit c31c81c7711888bed3801d6a5f470824dcd21845
Author: Robert Lyon <email address hidden>
Date: Fri Oct 16 12:44:23 2015 +1300

Bug 1501078: When sitethemeprefs is false / no theme select box

Need to check that $values['theme'] variable exists

behatnotneeded

Change-Id: Iba75b8306abdb01d876f4f402fc0a01a9bd2d49b
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5546

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5546
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/cef053ae9e96fe144d59999f6ae673899d070029
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit cef053ae9e96fe144d59999f6ae673899d070029
Author: Robert Lyon <email address hidden>
Date: Fri Oct 16 12:44:23 2015 +1300

Bug 1501078: When sitethemeprefs is false / no theme select box

Need to check that $values['theme'] variable exists

behatnotneeded

Change-Id: Iba75b8306abdb01d876f4f402fc0a01a9bd2d49b
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit c31c81c7711888bed3801d6a5f470824dcd21845)

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.