Can't change image description in image selector in TinyMCE

Bug #1502373 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Critical
Son Nguyen
15.04
Fix Released
High
Robert Lyon
15.10
Fix Released
Undecided
Unassigned

Bug Description

Mahara 15.10RC1

When you want to add an image to text via TinyMCE and you are on the "Insert or edit image" modal, and you want to change / add a description, add tags or change the commenting properties, you can't do so because upon clicking the "Save" button, nothing happens. You are just taken out of the modal, which is not correct either.

The correct behavior should be that the new description, tags, comments properties are saved upon clicking the "Save" button and that you return to the modal where you can choose the image.

Steps to replicate:

1. Add a text block to a page.
2. In TinyMCE in edit mode of the text block, click the image icon.
3. In the "Image" panel, click the "Edit" button for an image and add a description, a tag and change the commenting status.
4. Click the "Save" button.
Expected result: The properties changed for the image when you click the "Edit" button next to the image again (or in Content -> Files). You can also continue selecting the image.

Actual result: The properties are not changed and upon clicking "Save" you are returned to the main TinyMCE window and have to click the image button again in order to add the image.

Son Nguyen (ngson2000)
Changed in mahara:
assignee: nobody → Son Nguyen (ngson2000)
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5472

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5472
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/d03fd4d8adc73c0f52dba7165f66d48fdb87c734
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit d03fd4d8adc73c0f52dba7165f66d48fdb87c734
Author: Son Nguyen <email address hidden>
Date: Wed Oct 7 11:08:06 2015 +1300

Updating image description in image selector in TinyMCE. Bug 1502373

behatnotneeded: this is a fix not a feature

Change-Id: I3ecc5facdcff97edf3dd8433dc17cc60c26243f5

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5557

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5557
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/ecf73554ed88db5297c1037de2a4239feae4fdf8
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit ecf73554ed88db5297c1037de2a4239feae4fdf8
Author: Son Nguyen <email address hidden>
Date: Wed Oct 7 11:08:06 2015 +1300

Updating image description in image selector in TinyMCE. Bug 1502373

behatnotneeded: this is a fix not a feature

Change-Id: I3ecc5facdcff97edf3dd8433dc17cc60c26243f5
(cherry picked from commit d03fd4d8adc73c0f52dba7165f66d48fdb87c734)

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/5580

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5580
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/1edc31d8681731051a00b5a173c0c0a21181373d
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit 1edc31d8681731051a00b5a173c0c0a21181373d
Author: Son Nguyen <email address hidden>
Date: Wed Oct 7 11:08:06 2015 +1300

Updating image description in image selector in TinyMCE. Bug 1502373

behatnotneeded: this is a fix not a feature

Change-Id: I3ecc5facdcff97edf3dd8433dc17cc60c26243f5

Aaron Wells (u-aaronw)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.