Mahara

site statistics for groups throws an error if cron hasn't yet run

Bug #1504335 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Robert Lyon
Mahara 15.10.0
15.10
Fix Released
Undecided
Unassigned

Bug Description

We need to check for bool false as well as less than two rows before displaying data

Revision history for this message
Robert Lyon (robertl-9) wrote :

This was fixed for institution stats but not for site stats

So will apply the same fix here

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5491

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5491
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/6077e81d0c1205b6e59e35f93af93f393479acc6
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 6077e81d0c1205b6e59e35f93af93f393479acc6
Author: Robert Lyon <email address hidden>
Date: Fri Oct 9 11:19:16 2015 +1300

Bug 1504335: Foreach loop error when no data to display

On the site statistics group tab for mysql sites

behatnotneeded: This is a warning error that shows only before first
cron run

Change-Id: I779f786dfeb636004d1fbf5816f81eb4eb61c106
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5529

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5529
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/cb833a97c4d799310214ba5a47b400d1995a65cf
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit cb833a97c4d799310214ba5a47b400d1995a65cf
Author: Robert Lyon <email address hidden>
Date: Fri Oct 9 11:19:16 2015 +1300

Bug 1504335: Foreach loop error when no data to display

On the site statistics group tab for mysql sites

behatnotneeded: This is a warning error that shows only before first
cron run

Change-Id: I779f786dfeb636004d1fbf5816f81eb4eb61c106
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 6077e81d0c1205b6e59e35f93af93f393479acc6)

Robert Lyon (robertl-9)
Changed in mahara:
milestone: 16.04.0 → 15.10.0
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.